@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Conpherence - make solo conversations be titled with viewer's name
Summary: Fixes T8251. I think this used to be "lucky handle" when it was all one giant terrible function, so restore previous functionality and have the title be the viewer's name in this case.
Test Plan: rocked a solo conpherence and saw my username as the title
Reviewers: chad, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T8251
Differential Revision: https://secure.phabricator.com/D12935
+8
-3
+8
-3
src/applications/conpherence/storage/ConpherenceThread.php
+8
-3
src/applications/conpherence/storage/ConpherenceThread.php
···
231
231
$handles = $this->getHandles();
232
232
$phids = $this->getOtherRecentParticipantPHIDs($viewer);
233
233
234
-
$limit = 3;
235
-
$more = (count($phids) > $limit);
236
-
$phids = array_slice($phids, 0, $limit);
234
+
if (count($phids) == 0) {
235
+
$phids[] = $viewer->getPHID();
236
+
$more = false;
237
+
} else {
238
+
$limit = 3;
239
+
$more = (count($phids) > $limit);
240
+
$phids = array_slice($phids, 0, $limit);
241
+
}
237
242
238
243
$names = array_select_keys($handles, $phids);
239
244
$names = mpull($names, 'getName');