@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Don't require access to default EditConfiguration to view objects
Currently, to render comment actions you need to be able to see the
default form. Just make this work for now until it gets cleaned up.
+8
-1
+8
-1
src/applications/transactions/editengine/PhabricatorEditEngine.php
+8
-1
src/applications/transactions/editengine/PhabricatorEditEngine.php
···
191
191
}
192
192
193
193
private function loadEditEngineConfiguration($key) {
194
+
$viewer = $this->getViewer();
194
195
if ($key === null) {
195
196
$key = self::EDITENGINECONFIG_DEFAULT;
197
+
198
+
// TODO: At least for now, we need to load the default configuration
199
+
// in some cases (editing, comment actions) even if the viewer can not
200
+
// otherwise see it. This should be cleaned up eventually, but we can
201
+
// safely use the omnipotent user for now without policy violations.
202
+
$viewer = PhabricatorUser::getOmnipotentUser();
196
203
}
197
204
198
205
$config = id(new PhabricatorEditEngineConfigurationQuery())
199
-
->setViewer($this->getViewer())
206
+
->setViewer($viewer)
200
207
->withEngineKeys(array($this->getEngineKey()))
201
208
->withIdentifiers(array($key))
202
209
->executeOne();