@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Switch back to janky array copying
Summary: Bad news @cpojer @tomo. IE8 doesn't like you.
Test Plan: Load a diff in IE8; see changes and don't get JS errors.
Reviewers: #blessed_reviewers, epriestley
Reviewed By: #blessed_reviewers, epriestley
Subscribers: epriestley, tomo, Korvin, cpojer
Differential Revision: https://secure.phabricator.com/D8728
authored by
Ben Alpert
and committed by
epriestley
597c6c07
a7272dfb
+10
-4
+3
-3
resources/celerity/map.php
+3
-3
resources/celerity/map.php
···
14
14
'differential.pkg.js' => '11a5b750',
15
15
'diffusion.pkg.css' => '3783278d',
16
16
'diffusion.pkg.js' => '5b4010f4',
17
-
'javelin.pkg.js' => 'ec6c9ac3',
17
+
'javelin.pkg.js' => 'a10417f3',
18
18
'maniphest.pkg.css' => 'f1887d71',
19
19
'maniphest.pkg.js' => '2fe8af22',
20
20
'rsrc/css/aphront/aphront-bars.css' => '231ac33c',
···
178
178
'rsrc/externals/javelin/core/init.js' => 'b88ab49e',
179
179
'rsrc/externals/javelin/core/init_node.js' => 'd7dde471',
180
180
'rsrc/externals/javelin/core/install.js' => '52a92793',
181
-
'rsrc/externals/javelin/core/util.js' => 'e1d96281',
181
+
'rsrc/externals/javelin/core/util.js' => '65b0b249',
182
182
'rsrc/externals/javelin/docs/Base.js' => '897bb199',
183
183
'rsrc/externals/javelin/docs/onload.js' => '81fb4862',
184
184
'rsrc/externals/javelin/ext/fx/Color.js' => '7e41274a',
···
655
655
'javelin-typeahead-source' => '62e18640',
656
656
'javelin-typeahead-static-source' => 'cdde23f1',
657
657
'javelin-uri' => 'd9a9b862',
658
-
'javelin-util' => 'e1d96281',
658
+
'javelin-util' => '65b0b249',
659
659
'javelin-vector' => '403a3dce',
660
660
'javelin-view' => '0f764c35',
661
661
'javelin-view-html' => 'e5b406f9',
+7
-1
webroot/rsrc/externals/javelin/core/util.js
+7
-1
webroot/rsrc/externals/javelin/core/util.js
···
49
49
* @group util
50
50
*/
51
51
JX.$A = function(object) {
52
-
return Array.prototype.slice.call(object);
52
+
// IE8 throws "JScript object expected" when trying to call
53
+
// Array.prototype.slice on a NodeList, so just copy items one by one here.
54
+
var r = [];
55
+
for (var ii = 0; ii < object.length; ii++) {
56
+
r.push(object[ii]);
57
+
}
58
+
return r;
53
59
};
54
60
55
61