recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Audit - allow queries for "partial" and "accepted" audits

Summary: Fixes T5871. These queries get to use the actual column on the commit table since they are about the "aggregate" state of different audits.

Test Plan: issues queries and got sensible results.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T5871

Differential Revision: https://secure.phabricator.com/D10271

Bob Trahan 59b626d2 df361470

+18
+2
src/applications/audit/query/PhabricatorCommitSearchEngine.php
··· 181 181 DiffusionCommitQuery::AUDIT_STATUS_ANY => pht('Any'), 182 182 DiffusionCommitQuery::AUDIT_STATUS_OPEN => pht('Open'), 183 183 DiffusionCommitQuery::AUDIT_STATUS_CONCERN => pht('Concern Raised'), 184 + DiffusionCommitQuery::AUDIT_STATUS_ACCEPTED => pht('Accepted'), 185 + DiffusionCommitQuery::AUDIT_STATUS_PARTIAL => pht('Partially Audited'), 184 186 ); 185 187 } 186 188
+16
src/applications/diffusion/query/DiffusionCommitQuery.php
··· 21 21 const AUDIT_STATUS_ANY = 'audit-status-any'; 22 22 const AUDIT_STATUS_OPEN = 'audit-status-open'; 23 23 const AUDIT_STATUS_CONCERN = 'audit-status-concern'; 24 + const AUDIT_STATUS_ACCEPTED = 'audit-status-accepted'; 25 + const AUDIT_STATUS_PARTIAL = 'audit-status-partial'; 24 26 25 27 private $needCommitData; 26 28 ··· 437 439 $status = $this->auditStatus; 438 440 if ($status !== null) { 439 441 switch ($status) { 442 + case self::AUDIT_STATUS_PARTIAL: 443 + $where[] = qsprintf( 444 + $conn_r, 445 + 'commit.auditStatus = %d', 446 + PhabricatorAuditCommitStatusConstants::PARTIALLY_AUDITED); 447 + break; 448 + case self::AUDIT_STATUS_ACCEPTED: 449 + $where[] = qsprintf( 450 + $conn_r, 451 + 'commit.auditStatus = %d', 452 + PhabricatorAuditCommitStatusConstants::FULLY_AUDITED); 453 + break; 440 454 case self::AUDIT_STATUS_CONCERN: 441 455 $where[] = qsprintf( 442 456 $conn_r, ··· 462 476 self::AUDIT_STATUS_ANY, 463 477 self::AUDIT_STATUS_OPEN, 464 478 self::AUDIT_STATUS_CONCERN, 479 + self::AUDIT_STATUS_ACCEPTED, 480 + self::AUDIT_STATUS_PARTIAL, 465 481 ); 466 482 throw new Exception( 467 483 "Unknown audit status '{$status}'! Valid statuses are: ".