@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Clean up BadgeView a little bit
Summary: Uses BLUE_PROPERTY on Recipients box, removes redundent properties since we render the badge itself already.
Test Plan: View a badge with and without a description.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D15553
+5
-21
+1
-19
src/applications/badges/controller/PhabricatorBadgesViewController.php
+1
-19
src/applications/badges/controller/PhabricatorBadgesViewController.php
···
70
70
$timeline,
71
71
$add_comment,
72
72
))
73
-
->addPropertySection(pht('BADGE DETAILS'), $details);
73
+
->addPropertySection(pht('DESCRIPTION'), $details);
74
74
75
75
return $this->newPage()
76
76
->setTitle($title)
···
86
86
$view = id(new PHUIPropertyListView())
87
87
->setUser($viewer);
88
88
89
-
$quality_name = PhabricatorBadgesQuality::getQualityName(
90
-
$badge->getQuality());
91
-
92
-
$view->addProperty(
93
-
pht('Quality'),
94
-
$quality_name);
95
-
96
-
$view->addProperty(
97
-
pht('Icon'),
98
-
id(new PhabricatorBadgesIconSet())
99
-
->getIconLabel($badge->getIcon()));
100
-
101
-
$view->addProperty(
102
-
pht('Flavor'),
103
-
$badge->getFlavor());
104
-
105
89
$description = $badge->getDescription();
106
90
if (strlen($description)) {
107
-
$view->addSectionHeader(
108
-
pht('Description'), PHUIPropertyListView::ICON_SUMMARY);
109
91
$view->addTextContent(
110
92
new PHUIRemarkupView($viewer, $description));
111
93
}
+4
-2
src/applications/badges/view/PhabricatorBadgesRecipientsListView.php
+4
-2
src/applications/badges/view/PhabricatorBadgesRecipientsListView.php
···
27
27
PhabricatorPolicyCapability::CAN_EDIT);
28
28
29
29
$list = id(new PHUIObjectItemListView())
30
-
->setNoDataString(pht('This badge does not have any recipients.'));
30
+
->setNoDataString(pht('This badge does not have any recipients.'))
31
+
->setFlush(true);
31
32
32
33
foreach ($handles as $handle) {
33
34
$remove_uri = '/badges/recipients/'.
···
51
52
}
52
53
53
54
$box = id(new PHUIObjectBoxView())
54
-
->setHeaderText(pht('Recipients'))
55
+
->setHeaderText(pht('RECIPIENTS'))
56
+
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
55
57
->setObjectList($list);
56
58
57
59
return $box;