@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Revert "Have DifferentialRevisionList return an ObjectBox if header is set"
This did bad things to dashboards, pulling it back until we have a more complete fix.
This reverts commit 468985c8275e80a0585298d2763fe363473054cf.
Auditors: chad
+10
-19
+3
-3
resources/celerity/map.php
+3
-3
resources/celerity/map.php
···
7
7
*/
8
8
return array(
9
9
'names' => array(
10
-
'core.pkg.css' => 'adb53fe7',
10
+
'core.pkg.css' => '8be366b7',
11
11
'core.pkg.js' => '65e04767',
12
12
'darkconsole.pkg.js' => '8ab24e01',
13
13
'differential.pkg.css' => '8af45893',
···
137
137
'rsrc/css/phui/phui-info-panel.css' => '27ea50a1',
138
138
'rsrc/css/phui/phui-list.css' => '53deb25c',
139
139
'rsrc/css/phui/phui-object-box.css' => 'b8b7fd78',
140
-
'rsrc/css/phui/phui-object-item-list-view.css' => 'ace03f3e',
140
+
'rsrc/css/phui/phui-object-item-list-view.css' => '2670a4a9',
141
141
'rsrc/css/phui/phui-pinboard-view.css' => '3dd4a269',
142
142
'rsrc/css/phui/phui-property-list-view.css' => '51480060',
143
143
'rsrc/css/phui/phui-remarkup-preview.css' => '19ad512b',
···
785
785
'phui-info-panel-css' => '27ea50a1',
786
786
'phui-list-view-css' => '53deb25c',
787
787
'phui-object-box-css' => 'b8b7fd78',
788
-
'phui-object-item-list-view-css' => 'ace03f3e',
788
+
'phui-object-item-list-view-css' => '2670a4a9',
789
789
'phui-pinboard-view-css' => '3dd4a269',
790
790
'phui-property-list-view-css' => '51480060',
791
791
'phui-remarkup-preview-css' => '19ad512b',
+3
-2
src/applications/differential/controller/DifferentialRevisionViewController.php
+3
-2
src/applications/differential/controller/DifferentialRevisionViewController.php
···
778
778
$user = $this->getRequest()->getUser();
779
779
780
780
$view = id(new DifferentialRevisionListView())
781
-
->setHeader(pht('Open Revisions Affecting These Files'))
782
781
->setRevisions($revisions)
783
782
->setUser($user);
784
783
···
786
785
$handles = $this->loadViewerHandles($phids);
787
786
$view->setHandles($handles);
788
787
789
-
return $view;
788
+
return id(new PHUIObjectBoxView())
789
+
->setHeaderText(pht('Open Revisions Affecting These Files'))
790
+
->appendChild($view);
790
791
}
791
792
792
793
+1
-8
src/applications/differential/view/DifferentialRevisionListView.php
+1
-8
src/applications/differential/view/DifferentialRevisionListView.php
···
179
179
$list->addItem($item);
180
180
}
181
181
182
+
$list->setHeader($this->header);
182
183
$list->setNoDataString($this->noDataString);
183
-
184
-
185
-
if ($this->header) {
186
-
$list->setFlush(true);
187
-
$list = id(new PHUIObjectBoxView())
188
-
->setHeaderText($this->header)
189
-
->appendChild($list);
190
-
}
191
184
192
185
return $list;
193
186
}
+3
-2
src/applications/diffusion/controller/DiffusionBrowseController.php
+3
-2
src/applications/diffusion/controller/DiffusionBrowseController.php
···
208
208
}
209
209
210
210
$view = id(new DifferentialRevisionListView())
211
-
->setHeader(pht('Pending Differential Revisions'))
212
211
->setRevisions($revisions)
213
212
->setUser($user);
214
213
···
216
215
$handles = $this->loadViewerHandles($phids);
217
216
$view->setHandles($handles);
218
217
219
-
return $view;
218
+
return id(new PHUIObjectBoxView())
219
+
->setHeaderText(pht('Pending Differential Revisions'))
220
+
->appendChild($view);
220
221
}
221
222
222
223
}