@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Put cows and figlet bannners in <pre> in HTML mail bodies
Summary: Fixes T9538. Ref T9408. `cowsay` and `figlet` Remarkup rules are being mangled in HTML mail right now. Put them in <pre> to unmangle them.
Test Plan:
Sent myself a cow + figlet in mail.
Used `bin/mail show-outbound --id ... --dump-html > dump.html` + open that HTML file in Safari to preview HTML mail.
Saw linebreaks and monospaced formatting.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T9538, T9408
Differential Revision: https://secure.phabricator.com/D14248
+14
-2
+7
-1
src/infrastructure/markup/interpreter/PhabricatorRemarkupCowsayBlockInterpreter.php
+7
-1
src/infrastructure/markup/interpreter/PhabricatorRemarkupCowsayBlockInterpreter.php
···
28
28
->setText($content)
29
29
->renderCow();
30
30
31
-
if ($this->getEngine()->isTextMode()) {
31
+
$engine = $this->getEngine();
32
+
33
+
if ($engine->isTextMode()) {
32
34
return $result;
35
+
}
36
+
37
+
if ($engine->isHTMLMailMode()) {
38
+
return phutil_tag('pre', array(), $result);
33
39
}
34
40
35
41
return phutil_tag(
+7
-1
src/infrastructure/markup/interpreter/PhabricatorRemarkupFigletBlockInterpreter.php
+7
-1
src/infrastructure/markup/interpreter/PhabricatorRemarkupFigletBlockInterpreter.php
···
27
27
28
28
$result = $figlet->lineEcho($content);
29
29
30
-
if ($this->getEngine()->isTextMode()) {
30
+
$engine = $this->getEngine();
31
+
32
+
if ($engine->isTextMode()) {
31
33
return $result;
34
+
}
35
+
36
+
if ($engine->isHTMLMailMode()) {
37
+
return phutil_tag('pre', array(), $result);
32
38
}
33
39
34
40
return phutil_tag(