recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix PHP 8.1 "strlen(null)" exceptions handling empty comment metadata in PhabricatorEditEngine

Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/transactions/editengine/PhabricatorEditEngine.php:1923]
```

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/transactions/editengine/PhabricatorEditEngine.php:2023]
```

Closes T15864

Test Plan: See steps in https://we.phorge.it/T15864

Reviewers: O1 Blessed Committers, speck

Reviewed By: O1 Blessed Committers, speck

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15864

Differential Revision: https://we.phorge.it/D25699

Andre Klapper 5a9cf81a 68762e82

+2 -2
+2 -2
src/applications/transactions/editengine/PhabricatorEditEngine.php
··· 1920 1920 $comment_text = $request->getStr('comment'); 1921 1921 1922 1922 $comment_metadata = $request->getStr('comment_metadata'); 1923 - if (strlen($comment_metadata)) { 1923 + if (phutil_nonempty_string($comment_metadata)) { 1924 1924 $comment_metadata = phutil_json_decode($comment_metadata); 1925 1925 } 1926 1926 ··· 2020 2020 $xactions[] = $xaction; 2021 2021 } 2022 2022 2023 - if (strlen($comment_text) || !$xactions) { 2023 + if (phutil_nonempty_string($comment_text) || !$xactions) { 2024 2024 $xactions[] = id(clone $template) 2025 2025 ->setTransactionType(PhabricatorTransactions::TYPE_COMMENT) 2026 2026 ->setMetadataValue('remarkup.control', $comment_metadata)