@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix an outdated HTML anchor link in Diffusion table of contents
Summary:
See <https://discourse.phabricator-community.org/t/navigating-to-changed-files-in-diffusion-does-not-work-anymore/433>.
In D18465, I updated these but this hard-coded the anchor for some reason (???) and I missed it while `grep`-ing.
Test Plan: Viewed a commit (`/rXYZaaaa`) and clicked a file link in the table of contents. Got modern `#change-...` anchor and navigation into the document.
Reviewers: amckinley
Reviewed By: amckinley
Differential Revision: https://secure.phabricator.com/D18609
+1
-1
+1
-1
src/applications/diffusion/controller/DiffusionCommitController.php
+1
-1
src/applications/diffusion/controller/DiffusionCommitController.php
···
946
946
947
947
foreach ($changesets as $changeset_id => $changeset) {
948
948
$path = $changeset->getFilename();
949
-
$anchor = substr(md5($path), 0, 8);
949
+
$anchor = $changeset->getAnchorName();
950
950
951
951
$history_link = $diffusion_view->linkHistory($path);
952
952
$browse_link = $diffusion_view->linkBrowse(