@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Calendar event monograms, part 2. Calendar event monogram should appear in the object crumbs and page titles.
Summary: Ref T7928, Calendar event monograms, part 2. Calendar event monogram should appear in the object crumbs and page titles.
Test Plan: Create calendar event, event details page should show a clickable crumb, E{id}, and clicking edit should show a page where the crumbs show E{id} > Update Event
Reviewers: #blessed_reviewers, epriestley
Reviewed By: #blessed_reviewers, epriestley
Subscribers: epriestley, Korvin
Maniphest Tasks: T7928
Differential Revision: https://secure.phabricator.com/D12579
+9
-5
+7
-3
src/applications/calendar/controller/PhabricatorCalendarEventEditController.php
+7
-3
src/applications/calendar/controller/PhabricatorCalendarEventEditController.php
···
183
183
$nav = $this->buildSideNavView($status);
184
184
$nav->selectFilter($filter);
185
185
186
-
$crumbs = $this
187
-
->buildApplicationCrumbs()
188
-
->addTextCrumb($page_title);
186
+
$crumbs = $this->buildApplicationCrumbs();
187
+
188
+
if (!$this->isCreate()) {
189
+
$crumbs->addTextCrumb('E'.$status->getId(), '/E'.$status->getId());
190
+
}
191
+
192
+
$crumbs->addTextCrumb($page_title);
189
193
190
194
$nav->appendChild(
191
195
array(
+2
-2
src/applications/calendar/controller/PhabricatorCalendarEventViewController.php
+2
-2
src/applications/calendar/controller/PhabricatorCalendarEventViewController.php
···
25
25
return new Aphront404Response();
26
26
}
27
27
28
-
$title = pht('Event %d', $event->getID());
28
+
$title = 'E'.$event->getID();
29
29
$crumbs = $this->buildApplicationCrumbs();
30
-
$crumbs->addTextCrumb($title);
30
+
$crumbs->addTextCrumb($title, '/E'.$event->getID());
31
31
32
32
$header = $this->buildHeaderView($event);
33
33
$actions = $this->buildActionView($event);