recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix PHP 8.1 "ltrim(null)" exception creating a Nuance Source

Summary:
Passing `null` as the first parameter to `ltrim()` is deprecated since PHP 8.1.
Thus change the optional parameter of the function from null to an empty string.
```
ERROR 8192: ltrim(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/src/applications/nuance/source/NuanceSourceDefinition.php:211]
```
Closes T16000

Test Plan:
* Create a Nuance queue at `/nuance/queue/edit/form/default/`
* Create a Nuance "Web Form" type source at `/nuance/source/edit/form/default/`

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16000

Differential Revision: https://we.phorge.it/D25890

Andre Klapper 5b871388 035d7b28

+1 -1
+1 -1
src/applications/nuance/source/NuanceSourceDefinition.php
··· 206 206 return new Aphront404Response(); 207 207 } 208 208 209 - public function getActionURI($path = null) { 209 + public function getActionURI($path = '') { 210 210 $source_id = $this->getSource()->getID(); 211 211 return '/action/'.$source_id.'/'.ltrim($path, '/'); 212 212 }