recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Correct issue with "bindings" conduit attachment

Summary: Ref T13641. These conditions are swapped, and "activeBindings" loads more data than necessary while "bindings" doesn't load enough.

Test Plan: Called method with each attachment, got good results instead of an exception.

Maniphest Tasks: T13641

Differential Revision: https://secure.phabricator.com/D21657

epriestley 5b8b5f21 61272e7a

+2 -2
+2 -2
src/applications/almanac/engineextension/AlmanacBindingsSearchEngineAttachment.php
··· 26 26 $query->needProperties(true); 27 27 28 28 if ($this->getIsActive()) { 29 - $query->needBindings(true); 30 - } else { 31 29 $query->needActiveBindings(true); 30 + } else { 31 + $query->needBindings(true); 32 32 } 33 33 } 34 34