recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix two issues with callsign-free repositories

Summary:
Ref T4245. These callsites don't quite do the right thing if a repository has no callsign.

See also <https://github.com/phacility/phabricator/pull/822>.

Test Plan: Made a comment on a commit in a repository with no callsign.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T4245

Differential Revision: https://secure.phabricator.com/D15344

epriestley 5b9d8aea 944539a7

+2 -4
+1 -3
src/applications/audit/controller/PhabricatorAuditAddCommentController.php
··· 82 82 $draft->delete(); 83 83 } 84 84 85 - $monogram = $commit->getRepository()->getMonogram(); 86 - $identifier = $commit->getCommitIdentifier(); 87 - $uri = '/'.$monogram.$identifier; 85 + $uri = $commit->getURI(); 88 86 89 87 return id(new AphrontRedirectResponse())->setURI($uri); 90 88 }
+1 -1
src/applications/diffusion/controller/DiffusionExternalController.php
··· 103 103 array( 104 104 'href' => $href, 105 105 ), 106 - $commit->getMonogram()), 106 + $commit->getURI()), 107 107 $commit->loadCommitData()->getSummary(), 108 108 ); 109 109 }