@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Add instructions to Create Repository form fields for Callsign and Short Name
Summary:
When I create new repos, I always forget which is which (between Callsign and Short Name)
This adds helpful text as a placeholder and as control instructions
I am not sure if this layout is 100% better, but this is an option as well
**Add new Repository**
{F3169761 width=800}
**Edit existing Repository**
{F3169775 width=800}
Closes T15742
Test Plan: Added a new repository and saw these control instructions
Reviewers: O1 Blessed Committers, aklapper
Reviewed By: O1 Blessed Committers, aklapper
Subscribers: aklapper, avivey, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Maniphest Tasks: T15742
Differential Revision: https://we.phorge.it/D25898
+6
+6
src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php
+6
src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php
···
287
287
id(new PhabricatorTextEditField())
288
288
->setKey('callsign')
289
289
->setLabel(pht('Callsign'))
290
+
->setControlInstructions(
291
+
pht('Callsign is the monogram rXXXX for this repository. '.
292
+
'It cannot contain spaces.'))
290
293
->setTransactionType(
291
294
PhabricatorRepositoryCallsignTransaction::TRANSACTIONTYPE)
292
295
->setDescription(pht('The repository callsign.'))
···
296
299
id(new PhabricatorTextEditField())
297
300
->setKey('shortName')
298
301
->setLabel(pht('Short Name'))
302
+
->setControlInstructions(
303
+
pht('Short Name is part of the URI paths for this repository. '.
304
+
'It cannot contain spaces.'))
299
305
->setTransactionType(
300
306
PhabricatorRepositorySlugTransaction::TRANSACTIONTYPE)
301
307
->setDescription(pht('Short, unique repository name.'))