-5

src/aphront/configuration/AphrontDefaultApplicationConfiguration.php

reviewed

··· 121 121 '' => 'DrydockResourceListController', 122 122 'resource/' => 'DrydockResourceListController', 123 123 'resource/allocate/' => 'DrydockResourceAllocateController', 124 124 - 'host/' => array( 125 125 - '' => 'DrydockHostListController', 126 126 - 'edit/' => 'DrydockHostEditController', 127 127 - 'edit/(?P<id>\d+)/' => 'DrydockhostEditController', 128 128 - ), 129 124 'lease/' => 'DrydockLeaseListController', 130 125 'log/' => 'DrydockLogController', 131 126 ),

+2

src/applications/auth/controller/PhabricatorOAuthDiagnosticsController.php

reviewed

··· 19 19 final class PhabricatorOAuthDiagnosticsController 20 20 extends PhabricatorAuthController { 21 21 22 22 + private $provider; 23 23 + 22 24 public function shouldRequireLogin() { 23 25 return false; 24 26 }

+2

src/applications/countdown/controller/PhabricatorCountdownDeleteController.php

reviewed

··· 19 19 final class PhabricatorCountdownDeleteController 20 20 extends PhabricatorCountdownController { 21 21 22 22 + private $id; 23 23 + 22 24 public function willProcessRequest(array $data) { 23 25 $this->id = $data['id']; 24 26 }

+2

src/applications/herald/storage/HeraldRule.php

reviewed

··· 32 32 33 33 private $ruleApplied = array(); // phids for which this rule has been applied 34 34 private $invalidOwner = false; 35 35 + private $conditions; 36 36 + private $actions; 35 37 36 38 public static function loadAllByContentTypeWithFullData( 37 39 $content_type,

+1

src/applications/herald/view/HeraldRuleEditHistoryView.php

reviewed

··· 20 20 21 21 private $edits; 22 22 private $handles; 23 23 + private $user; 23 24 24 25 public function setEdits(array $edits) { 25 26 $this->edits = $edits;

-5

src/applications/ponder/controller/PonderFeedController.php

reviewed

··· 24 24 25 25 public function willProcessRequest(array $data) { 26 26 $this->page = idx($data, 'page'); 27 27 - $this->feedOffset = idx($data, 'feedoffset'); 28 27 } 29 28 30 29 public function processRequest() { ··· 81 80 self::PROFILE_ANSWER_PAGE_SIZE + 1 82 81 ); 83 82 84 84 - $phids = array($user->getPHID()); 85 85 - $handles = $this->loadViewerHandles($phids); 86 86 - 87 83 $side_nav->appendChild( 88 84 id(new PonderUserProfileView()) 89 85 ->setUser($user) 90 86 ->setAnswers($answers) 91 91 - ->setHandles($handles) 92 87 ->setAnswerOffset($this->answerOffset) 93 88 ->setPageSize(self::PROFILE_ANSWER_PAGE_SIZE) 94 89 ->setURI(new PhutilURI("/ponder/profile/"), "aoff")

-6

src/applications/ponder/view/PonderUserProfileView.php

reviewed

··· 50 50 return $this; 51 51 } 52 52 53 53 - public function setHandles($handles) { 54 54 - $this->handles = $handles; 55 55 - return $this; 56 56 - } 57 57 - 58 53 public function setURI($uri, $aparam) { 59 54 $this->uri = $uri; 60 55 $this->aparam = $aparam; ··· 68 63 $user = $this->user; 69 64 $aoffset = $this->answeroffset; 70 65 $answers = $this->answers; 71 71 - $handles = $this->handles; 72 66 $uri = $this->uri; 73 67 $aparam = $this->aparam; 74 68 $pagesize = $this->pagesize;

+2

src/applications/project/controller/PhabricatorProjectMembersEditController.php

reviewed

··· 19 19 final class PhabricatorProjectMembersEditController 20 20 extends PhabricatorProjectController { 21 21 22 22 + private $id; 23 23 + 22 24 public function willProcessRequest(array $data) { 23 25 $this->id = $data['id']; 24 26 }

+2

src/applications/project/controller/PhabricatorProjectProfileEditController.php

reviewed

··· 19 19 final class PhabricatorProjectProfileEditController 20 20 extends PhabricatorProjectController { 21 21 22 22 + private $id; 23 23 + 22 24 public function willProcessRequest(array $data) { 23 25 $this->id = $data['id']; 24 26 }

+2 -2

src/applications/xhpastview/controller/PhabricatorXHPASTViewPanelController.php

reviewed

··· 1 1 <?php 2 2 3 3 /* 4 4 - * Copyright 2011 Facebook, Inc. 4 4 + * Copyright 2012 Facebook, Inc. 5 5 * 6 6 * Licensed under the Apache License, Version 2.0 (the "License"); 7 7 * you may not use this file except in compliance with the License. ··· 20 20 extends PhabricatorXHPASTViewController { 21 21 22 22 private $id; 23 23 - private $tree; 23 23 + private $storageTree; 24 24 25 25 public function willProcessRequest(array $data) { 26 26 $this->id = $data['id'];

+2

src/view/layout/PhabricatorPinboardItemView.php

reviewed

··· 22 22 private $uri; 23 23 private $header; 24 24 25 25 + private $imageWidth; 26 26 + private $imageHeight; 25 27 26 28 public function setHeader($header) { 27 29 $this->header = $header;