@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Convert date-marker to ModularTransaction in Conpherence
Summary: Swaps this transaction over.
Test Plan: Load up a few rooms with date markers, still render as expected.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Maniphest Tasks: T12550
Differential Revision: https://secure.phabricator.com/D17680
+13
-7
+2
src/__phutil_library_map__.php
+2
src/__phutil_library_map__.php
···
316
316
'ConpherenceTestCase' => 'applications/conpherence/__tests__/ConpherenceTestCase.php',
317
317
'ConpherenceThread' => 'applications/conpherence/storage/ConpherenceThread.php',
318
318
'ConpherenceThreadDatasource' => 'applications/conpherence/typeahead/ConpherenceThreadDatasource.php',
319
+
'ConpherenceThreadDateMarkerTransaction' => 'applications/conpherence/xaction/ConpherenceThreadDateMarkerTransaction.php',
319
320
'ConpherenceThreadIndexEngineExtension' => 'applications/conpherence/engineextension/ConpherenceThreadIndexEngineExtension.php',
320
321
'ConpherenceThreadListView' => 'applications/conpherence/view/ConpherenceThreadListView.php',
321
322
'ConpherenceThreadMailReceiver' => 'applications/conpherence/mail/ConpherenceThreadMailReceiver.php',
···
5107
5108
'PhabricatorNgramsInterface',
5108
5109
),
5109
5110
'ConpherenceThreadDatasource' => 'PhabricatorTypeaheadDatasource',
5111
+
'ConpherenceThreadDateMarkerTransaction' => 'ConpherenceThreadTransactionType',
5110
5112
'ConpherenceThreadIndexEngineExtension' => 'PhabricatorIndexEngineExtension',
5111
5113
'ConpherenceThreadListView' => 'AphrontView',
5112
5114
'ConpherenceThreadMailReceiver' => 'PhabricatorObjectMailReceiver',
+2
-1
src/applications/conpherence/ConpherenceTransactionRenderer.php
+2
-1
src/applications/conpherence/ConpherenceTransactionRenderer.php
···
60
60
// between days. some setup required!
61
61
$previous_transaction = null;
62
62
$date_marker_transaction = id(new ConpherenceTransaction())
63
-
->setTransactionType(ConpherenceTransaction::TYPE_DATE_MARKER)
63
+
->setTransactionType(
64
+
ConpherenceThreadDateMarkerTransaction::TRANSACTIONTYPE)
64
65
->makeEphemeral();
65
66
$date_marker_transaction_view = id(new ConpherenceTransactionView())
66
67
->setUser($user)
-5
src/applications/conpherence/storage/ConpherenceTransaction.php
-5
src/applications/conpherence/storage/ConpherenceTransaction.php
···
4
4
extends PhabricatorModularTransaction {
5
5
6
6
const TYPE_PARTICIPANTS = 'participants';
7
-
const TYPE_DATE_MARKER = 'date-marker';
8
7
9
8
public function getApplicationName() {
10
9
return 'conpherence';
···
39
38
switch ($this->getTransactionType()) {
40
39
case self::TYPE_PARTICIPANTS:
41
40
return ($old === null);
42
-
case self::TYPE_DATE_MARKER:
43
-
return false;
44
41
}
45
42
46
43
return parent::shouldHide();
···
93
90
94
91
$phids[] = $this->getAuthorPHID();
95
92
switch ($this->getTransactionType()) {
96
-
case self::TYPE_DATE_MARKER:
97
-
break;
98
93
case self::TYPE_PARTICIPANTS:
99
94
$phids = array_merge($phids, $this->getOldValue());
100
95
$phids = array_merge($phids, $this->getNewValue());
+1
-1
src/applications/conpherence/view/ConpherenceTransactionView.php
+1
-1
src/applications/conpherence/view/ConpherenceTransactionView.php