@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Left nav should no longer offer to create Calendar event and create event page should no longer show left nav.
Summary: Closes T7934, Left nav should no longer offer to create Calendar event and create event page should no longer show left nav.
Test Plan: Open Calendar, left nav should be missing the Create Event option, create event, create view should no longer show left nav.
Reviewers: epriestley, #blessed_reviewers
Reviewed By: epriestley, #blessed_reviewers
Subscribers: Korvin, epriestley
Maniphest Tasks: T7934
Differential Revision: https://secure.phabricator.com/D12638
+2
-12
-1
src/applications/calendar/controller/PhabricatorCalendarController.php
-1
src/applications/calendar/controller/PhabricatorCalendarController.php
···
10
10
$nav->addLabel(pht('Calendar'));
11
11
$nav->addFilter('/', pht('My Events'));
12
12
$nav->addFilter('all/', pht('View All'));
13
-
$nav->addFilter('event/create/', pht('Create Event'));
14
13
15
14
if ($status && $status->getID()) {
16
15
$nav->addFilter('event/edit/'.$status->getID().'/', pht('Edit Event'));
+2
-11
src/applications/calendar/controller/PhabricatorCalendarEventEditController.php
+2
-11
src/applications/calendar/controller/PhabricatorCalendarEventEditController.php
···
37
37
$end_value = $end_time->readValueFromRequest($request);
38
38
$start_value = $start_time->readValueFromRequest($request);
39
39
$submit_label = pht('Create');
40
-
$filter = 'event/create/';
41
40
$page_title = pht('Create Event');
42
41
$redirect = 'created';
43
42
$subscribers = array();
···
59
58
$end_time->setValue($event->getDateTo());
60
59
$start_time->setValue($event->getDateFrom());
61
60
$submit_label = pht('Update');
62
-
$filter = 'event/edit/'.$event->getID().'/';
63
61
$page_title = pht('Update Event');
64
-
$redirect = 'updated';
65
62
66
63
$subscribers = PhabricatorSubscribersQuery::loadSubscribersForPHID(
67
64
$event->getPHID());
···
245
242
->setFormErrors($errors)
246
243
->setForm($form);
247
244
248
-
$nav = $this->buildSideNavView($event);
249
-
$nav->selectFilter($filter);
250
-
251
245
$crumbs = $this->buildApplicationCrumbs();
252
246
253
247
if (!$this->isCreate()) {
···
261
255
->setValidationException($validation_exception)
262
256
->appendChild($form);
263
257
264
-
$nav->appendChild(
258
+
return $this->buildApplicationPage(
265
259
array(
266
260
$crumbs,
267
261
$object_box,
268
-
));
269
-
270
-
return $this->buildApplicationPage(
271
-
$nav,
262
+
),
272
263
array(
273
264
'title' => $page_title,
274
265
));