@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Expand "local working copy" conditional check in Diffusion
Summary: We don't care about any disk resources at all for non-hosted SVN repositories. See <https://github.com/facebook/phabricator/issues/428>.
Test Plan: Looked at a non-hosted SVN repo, saw no storage info.
Reviewers: btrahan, chad
Reviewed By: chad
CC: aran
Differential Revision: https://secure.phabricator.com/D7506
+20
-20
+20
-20
src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php
+20
-20
src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php
···
726
726
->setNote($daemon_instructions));
727
727
}
728
728
729
-
$local_parent = dirname($repository->getLocalPath());
730
-
if (Filesystem::pathExists($local_parent)) {
731
-
$view->addItem(
732
-
id(new PHUIStatusItemView())
733
-
->setIcon('accept-green')
734
-
->setTarget(pht('Storage Directory OK'))
735
-
->setNote(phutil_tag('tt', array(), $local_parent)));
736
-
} else {
737
-
$view->addItem(
738
-
id(new PHUIStatusItemView())
739
-
->setIcon('warning-red')
740
-
->setTarget(pht('No Storage Directory'))
741
-
->setNote(
742
-
pht(
743
-
'Storage directory %s does not exist, or is not readable by '.
744
-
'the webserver. Create this directory or make it readable.',
745
-
phutil_tag('tt', array(), $local_parent))));
746
-
return $view;
747
-
}
748
-
749
729
if ($repository->usesLocalWorkingCopy()) {
730
+
$local_parent = dirname($repository->getLocalPath());
731
+
if (Filesystem::pathExists($local_parent)) {
732
+
$view->addItem(
733
+
id(new PHUIStatusItemView())
734
+
->setIcon('accept-green')
735
+
->setTarget(pht('Storage Directory OK'))
736
+
->setNote(phutil_tag('tt', array(), $local_parent)));
737
+
} else {
738
+
$view->addItem(
739
+
id(new PHUIStatusItemView())
740
+
->setIcon('warning-red')
741
+
->setTarget(pht('No Storage Directory'))
742
+
->setNote(
743
+
pht(
744
+
'Storage directory %s does not exist, or is not readable by '.
745
+
'the webserver. Create this directory or make it readable.',
746
+
phutil_tag('tt', array(), $local_parent))));
747
+
return $view;
748
+
}
749
+
750
750
$local_path = $repository->getLocalPath();
751
751
$message = idx($messages, PhabricatorRepositoryStatusMessage::TYPE_INIT);
752
752
if ($message) {