@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix `adjust` phases for keys
Summary: Ref T1191. I renamed the phases but missed these two since I didn't have any more key issues locally.
Test Plan: Ran `bin/storage adjust` in production with key issues.
Reviewers: btrahan
Subscribers: chad, epriestley
Maniphest Tasks: T1191
Differential Revision: https://secure.phabricator.com/D10612
+2
-2
+2
-2
src/infrastructure/storage/management/workflow/PhabricatorStorageManagementAdjustWorkflow.php
+2
-2
src/infrastructure/storage/management/workflow/PhabricatorStorageManagementAdjustWorkflow.php
···
231
231
}
232
232
break;
233
233
case 'key':
234
-
if (($phase == 0) && $adjust['exists']) {
234
+
if (($phase == 'drop_keys') && $adjust['exists']) {
235
235
if ($adjust['name'] == 'PRIMARY') {
236
236
$key_name = 'PRIMARY KEY';
237
237
} else {
···
246
246
$key_name);
247
247
}
248
248
249
-
if (($phase == 2) && $adjust['keep']) {
249
+
if (($phase == 'add_keys') && $adjust['keep']) {
250
250
// Different keys need different creation syntax. Notable
251
251
// special cases are primary keys and fulltext keys.
252
252
if ($adjust['name'] == 'PRIMARY') {