@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix some Phabricator lint warnings
Summary: Lint.
Test Plan: Lint.
Reviewers: chad
Reviewed By: chad
CC: aran
Differential Revision: https://secure.phabricator.com/D6127
+18
-20
+1
-2
scripts/user/account_admin.php
+1
-2
scripts/user/account_admin.php
···
113
113
if (!$verify_email->getIsVerified()) {
114
114
$set_verified = phutil_console_confirm(
115
115
'Should the primary email address be verified?',
116
-
$default_no = true
117
-
);
116
+
$default_no = true);
118
117
} else {
119
118
// already verified so let's not make a fuss
120
119
$verify_email = null;
+7
-7
src/applications/differential/parser/DifferentialHunkParser.php
+7
-7
src/applications/differential/parser/DifferentialHunkParser.php
···
585
585
$end = $end + $add_context;
586
586
$hunk_content = array();
587
587
$hunk_pos = array( "-" => 0, "+" => 0 );
588
-
$hunk_offset = array( "-" => NULL, "+" => NULL );
589
-
$hunk_last = array( "-" => NULL, "+" => NULL );
588
+
$hunk_offset = array( "-" => null, "+" => null );
589
+
$hunk_last = array( "-" => null, "+" => null );
590
590
foreach (explode("\n", $hunk->getChanges()) as $line) {
591
591
$in_common = strncmp($line, " ", 1) === 0;
592
592
$in_old = strncmp($line, "-", 1) === 0 || $in_common;
···
598
598
if (!$skip || ($hunk_pos[$prefix] != $start &&
599
599
$hunk_pos[$prefix] != $end)) {
600
600
if ($in_old) {
601
-
if ($hunk_offset["-"] === NULL) {
601
+
if ($hunk_offset["-"] === null) {
602
602
$hunk_offset["-"] = $hunk_pos["-"];
603
603
}
604
604
$hunk_last["-"] = $hunk_pos["-"];
605
605
}
606
606
if ($in_new) {
607
-
if ($hunk_offset["+"] === NULL) {
607
+
if ($hunk_offset["+"] === null) {
608
608
$hunk_offset["+"] = $hunk_pos["+"];
609
609
}
610
610
$hunk_last["+"] = $hunk_pos["+"];
···
617
617
if ($in_new) { ++$hunk_pos["+"]; }
618
618
}
619
619
}
620
-
if ($hunk_offset["-"] !== NULL || $hunk_offset["+"] !== NULL) {
620
+
if ($hunk_offset["-"] !== null || $hunk_offset["+"] !== null) {
621
621
$header = "@@";
622
-
if ($hunk_offset["-"] !== NULL) {
622
+
if ($hunk_offset["-"] !== null) {
623
623
$header .= " -" . ($hunk->getOldOffset() + $hunk_offset["-"]) .
624
624
"," . ($hunk_last["-"] - $hunk_offset["-"] + 1);
625
625
}
626
-
if ($hunk_offset["+"] !== NULL) {
626
+
if ($hunk_offset["+"] !== null) {
627
627
$header .= " +" . ($hunk->getNewOffset() + $hunk_offset["+"]) .
628
628
"," . ($hunk_last["+"] - $hunk_offset["+"] + 1);
629
629
}
+2
-2
src/applications/differential/parser/__tests__/DifferentialHunkParserTestCase.php
+2
-2
src/applications/differential/parser/__tests__/DifferentialHunkParserTestCase.php
···
9
9
// $length: 0 based (0 meaning 1 line)
10
10
private function createNewComment($line, $length) {
11
11
$comment = $this->createComment();
12
-
$comment->setIsNewFile(True);
12
+
$comment->setIsNewFile(true);
13
13
$comment->setLineNumber($line);
14
14
$comment->setLineLength($length);
15
15
return $comment;
···
18
18
// $length: 0 based (0 meaning 1 line)
19
19
private function createOldComment($line, $length) {
20
20
$comment = $this->createComment();
21
-
$comment->setIsNewFile(False);
21
+
$comment->setIsNewFile(false);
22
22
$comment->setLineNumber($line);
23
23
$comment->setLineLength($length);
24
24
return $comment;
+2
-2
src/applications/phid/PhabricatorObjectHandle.php
+2
-2
src/applications/phid/PhabricatorObjectHandle.php
+1
-1
src/applications/pholio/editor/PholioMockEditor.php
+1
-1
src/applications/pholio/editor/PholioMockEditor.php
···
144
144
$head = array();
145
145
$tail = array();
146
146
147
-
// Move inline comments to the end, so the comments preceed them.
147
+
// Move inline comments to the end, so the comments precede them.
148
148
foreach ($xactions as $xaction) {
149
149
$type = $xaction->getTransactionType();
150
150
if ($type == PholioTransactionType::TYPE_INLINE) {
+1
-1
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
+1
-1
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
···
841
841
$head = array();
842
842
$tail = array();
843
843
844
-
// Move bare comments to the end, so the actions preceed them.
844
+
// Move bare comments to the end, so the actions precede them.
845
845
foreach ($xactions as $xaction) {
846
846
$type = $xaction->getTransactionType();
847
847
if ($type == PhabricatorTransactions::TYPE_COMMENT) {
+1
-1
src/infrastructure/daemon/bot/adapter/PhabricatorBotBaseStreamingProtocolAdapter.php
+1
-1
src/infrastructure/daemon/bot/adapter/PhabricatorBotBaseStreamingProtocolAdapter.php
+1
-1
src/infrastructure/edges/editor/PhabricatorEdgeEditor.php
+1
-1
src/infrastructure/edges/editor/PhabricatorEdgeEditor.php
···
355
355
* response to edits, and is primarily useful when performing migrations. You
356
356
* should not normally need to use it.
357
357
*
358
-
* @param bool True to supress events related to edits.
358
+
* @param bool True to suppress events related to edits.
359
359
* @return this
360
360
* @task internal
361
361
*/
+1
-2
src/view/layout/PhabricatorCrumbsView.php
+1
-2
src/view/layout/PhabricatorCrumbsView.php
+1
-1
src/view/phui/PHUIFeedStoryView.php
+1
-1
src/view/phui/PHUIFeedStoryView.php