@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Hide the Differential keyboard focus reticle after Quicksand navigation
Summary: Ref T8047. Ref T12634. When we sleep, hide the reticle. Restore it when we wake.
Test Plan:
- With Quicksand enabled..
- Used "j" to select a change in a revision.
- Navigated away by clicking a link.
- WOW! Reticle vanished properly!
- Used "back" to return.
- Reticle returned properly.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T12634, T8047
Differential Revision: https://secure.phabricator.com/D17900
+21
-17
+16
-16
resources/celerity/map.php
+16
-16
resources/celerity/map.php
···
10
10
'conpherence.pkg.css' => 'ff161f2d',
11
11
'conpherence.pkg.js' => 'b5b51108',
12
12
'core.pkg.css' => 'ee5f28cd',
13
-
'core.pkg.js' => '2ff7879f',
13
+
'core.pkg.js' => '115cb4da',
14
14
'darkconsole.pkg.js' => '1f9a31bc',
15
15
'differential.pkg.css' => '58712637',
16
-
'differential.pkg.js' => '5ee318c2',
16
+
'differential.pkg.js' => 'd831041b',
17
17
'diffusion.pkg.css' => 'b93d9b8c',
18
18
'diffusion.pkg.js' => '84c8f8fd',
19
19
'favicon.ico' => '30672e08',
···
391
391
'rsrc/js/application/dashboard/behavior-dashboard-query-panel-select.js' => '453c5375',
392
392
'rsrc/js/application/dashboard/behavior-dashboard-tab-panel.js' => 'd4eecc63',
393
393
'rsrc/js/application/diff/DiffChangeset.js' => 'f7100923',
394
-
'rsrc/js/application/diff/DiffChangesetList.js' => 'f10fd7a3',
394
+
'rsrc/js/application/diff/DiffChangesetList.js' => 'c457058f',
395
395
'rsrc/js/application/diff/DiffInline.js' => '00db3c3a',
396
396
'rsrc/js/application/diff/behavior-preview-link.js' => '051c7832',
397
397
'rsrc/js/application/differential/behavior-comment-jump.js' => '4fdb476d',
···
474
474
'rsrc/js/core/FileUpload.js' => '680ea2c8',
475
475
'rsrc/js/core/Hovercard.js' => '1bd28176',
476
476
'rsrc/js/core/KeyboardShortcut.js' => '1ae869f2',
477
-
'rsrc/js/core/KeyboardShortcutManager.js' => '4a021c10',
477
+
'rsrc/js/core/KeyboardShortcutManager.js' => 'c19dd9b9',
478
478
'rsrc/js/core/MultirowRowManager.js' => 'b5d57730',
479
479
'rsrc/js/core/Notification.js' => 'ccf1cbf8',
480
480
'rsrc/js/core/Prefab.js' => 'c5af80a2',
···
782
782
'phabricator-darkmessage' => 'c48cccdd',
783
783
'phabricator-dashboard-css' => 'fe5b1869',
784
784
'phabricator-diff-changeset' => 'f7100923',
785
-
'phabricator-diff-changeset-list' => 'f10fd7a3',
785
+
'phabricator-diff-changeset-list' => 'c457058f',
786
786
'phabricator-diff-inline' => '00db3c3a',
787
787
'phabricator-drag-and-drop-file-upload' => '58dea2fa',
788
788
'phabricator-draggable-list' => 'bea6e7f4',
···
793
793
'phabricator-filetree-view-css' => 'fccf9f82',
794
794
'phabricator-flag-css' => 'bba8f811',
795
795
'phabricator-keyboard-shortcut' => '1ae869f2',
796
-
'phabricator-keyboard-shortcut-manager' => '4a021c10',
796
+
'phabricator-keyboard-shortcut-manager' => 'c19dd9b9',
797
797
'phabricator-main-menu-view' => '5294060f',
798
798
'phabricator-nav-view-css' => 'faf6a6fc',
799
799
'phabricator-notification' => 'ccf1cbf8',
···
1253
1253
'javelin-dom',
1254
1254
'javelin-stratcom',
1255
1255
),
1256
-
'4a021c10' => array(
1257
-
'javelin-install',
1258
-
'javelin-util',
1259
-
'javelin-stratcom',
1260
-
'javelin-dom',
1261
-
'javelin-vector',
1262
-
),
1263
1256
'4b3c4443' => array(
1264
1257
'phuix-icon-view',
1265
1258
),
···
1916
1909
'javelin-install',
1917
1910
'javelin-dom',
1918
1911
),
1912
+
'c19dd9b9' => array(
1913
+
'javelin-install',
1914
+
'javelin-util',
1915
+
'javelin-stratcom',
1916
+
'javelin-dom',
1917
+
'javelin-vector',
1918
+
),
1919
1919
'c420b0b9' => array(
1920
1920
'javelin-behavior',
1921
1921
'javelin-behavior-device',
1922
1922
'javelin-stratcom',
1923
1923
'phabricator-tooltip',
1924
+
),
1925
+
'c457058f' => array(
1926
+
'javelin-install',
1924
1927
),
1925
1928
'c587b80f' => array(
1926
1929
'javelin-install',
···
2169
2172
'javelin-util',
2170
2173
'javelin-workflow',
2171
2174
'javelin-json',
2172
-
),
2173
-
'f10fd7a3' => array(
2174
-
'javelin-install',
2175
2175
),
2176
2176
'f50152ad' => array(
2177
2177
'phui-timeline-view-css',
+5
-1
webroot/rsrc/js/application/diff/DiffChangesetList.js
+5
-1
webroot/rsrc/js/application/diff/DiffChangesetList.js
···
67
67
68
68
sleep: function() {
69
69
this._asleep = true;
70
+
71
+
this._redrawFocus();
70
72
},
71
73
72
74
wake: function() {
73
75
this._asleep = false;
76
+
77
+
this._redrawFocus();
74
78
75
79
if (this._initialized) {
76
80
return;
···
650
654
var extended_node = this._focusEnd || node;
651
655
652
656
var reticle = this._getFocusNode();
653
-
if (!node) {
657
+
if (!node || this.isAsleep()) {
654
658
JX.DOM.remove(reticle);
655
659
return;
656
660
}