recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix deprecated argument order for "implode()"

Summary: Fixes T13428. In modern PHP, "implode()" should take the glue parameter first.

Test Plan:
Used the linter introduced in D20857 to identify affected callsites.

```
$ git grep -i implode | cut -d: -f1 | sort | uniq | xargs arc lint --output summary --never-apply-patches | grep -i glue
```

Maniphest Tasks: T13428

Differential Revision: https://secure.phabricator.com/D20858

epriestley 5dafabd5 7badec23

+6 -6
+1 -1
src/applications/differential/lipsum/PhabricatorDifferentialRevisionTestDataGenerator.php
··· 103 103 $newcode2[] = $altcodearr[$randomlines_new[$c++]]; 104 104 } 105 105 } 106 - return implode($newcode2, "\n"); 106 + return implode("\n", $newcode2); 107 107 } 108 108 109 109 }
+1 -1
src/applications/people/view/PhabricatorUserCardView.php
··· 38 38 } 39 39 40 40 return array( 41 - 'class' => implode($classes, ' '), 41 + 'class' => implode(' ', $classes), 42 42 ); 43 43 } 44 44
+1 -1
src/applications/project/view/PhabricatorProjectCardView.php
··· 36 36 $classes[] = 'project-card-'.$color; 37 37 38 38 return array( 39 - 'class' => implode($classes, ' '), 39 + 'class' => implode(' ', $classes), 40 40 ); 41 41 } 42 42
+2 -2
src/view/phui/PHUIPropertyListView.php
··· 284 284 return phutil_tag( 285 285 'div', 286 286 array( 287 - 'class' => implode($classes, ' '), 287 + 'class' => implode(' ', $classes), 288 288 ), 289 289 $part['content']); 290 290 } ··· 295 295 return phutil_tag( 296 296 'div', 297 297 array( 298 - 'class' => implode($classes, ' '), 298 + 'class' => implode(' ', $classes), 299 299 ), 300 300 $part['content']); 301 301 }
+1 -1
src/view/phui/PHUITwoColumnView.php
··· 220 220 return phutil_tag( 221 221 'div', 222 222 array( 223 - 'class' => implode($classes, ' '), 223 + 'class' => implode(' ', $classes), 224 224 ), 225 225 array( 226 226 $navigation,