recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remove Unused SupportApplication

Summary: Looks like this was accidentally introduced in rP039b8e43b98c962 along with PhabricatorHelpApplication, which covers the same URI with the same controller.

Test Plan: Load a page, hit `?`, see the shortcuts show up (and request for `/help/keyboardshortcut/` in the Network tab)

Reviewers: O1 Blessed Committers, aklapper

Reviewed By: O1 Blessed Committers, aklapper

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D26564

Aviv Eyal 5dcf8f6c 0e79feb3

+3 -27
-2
src/__phutil_library_map__.php
··· 4994 4994 'PhabricatorSubscriptionsUnsubscribeEmailCommand' => 'applications/subscriptions/command/PhabricatorSubscriptionsUnsubscribeEmailCommand.php', 4995 4995 'PhabricatorSubtypeEditEngineExtension' => 'applications/transactions/engineextension/PhabricatorSubtypeEditEngineExtension.php', 4996 4996 'PhabricatorSumChartFunction' => 'applications/fact/chart/PhabricatorSumChartFunction.php', 4997 - 'PhabricatorSupportApplication' => 'applications/support/application/PhabricatorSupportApplication.php', 4998 4997 'PhabricatorSyntaxHighlighter' => 'infrastructure/markup/PhabricatorSyntaxHighlighter.php', 4999 4998 'PhabricatorSyntaxHighlightingConfigOptions' => 'applications/config/option/PhabricatorSyntaxHighlightingConfigOptions.php', 5000 4999 'PhabricatorSyntaxStyle' => 'infrastructure/syntax/PhabricatorSyntaxStyle.php', ··· 11760 11759 'PhabricatorSubscriptionsUnsubscribeEmailCommand' => 'MetaMTAEmailTransactionCommand', 11761 11760 'PhabricatorSubtypeEditEngineExtension' => 'PhabricatorEditEngineExtension', 11762 11761 'PhabricatorSumChartFunction' => 'PhabricatorHigherOrderChartFunction', 11763 - 'PhabricatorSupportApplication' => 'PhabricatorApplication', 11764 11762 'PhabricatorSyntaxHighlighter' => 'Phobject', 11765 11763 'PhabricatorSyntaxHighlightingConfigOptions' => 'PhabricatorApplicationConfigOptions', 11766 11764 'PhabricatorSyntaxStyle' => 'Phobject',
+3
src/applications/diffusion/controller/DiffusionController.php
··· 4 4 5 5 private $diffusionRequest; 6 6 7 + /** 8 + * @return DiffusionRequest 9 + */ 7 10 protected function getDiffusionRequest() { 8 11 if (!$this->diffusionRequest) { 9 12 throw new PhutilInvalidStateException('loadDiffusionContext');
-25
src/applications/support/application/PhabricatorSupportApplication.php
··· 1 - <?php 2 - 3 - final class PhabricatorSupportApplication extends PhabricatorApplication { 4 - 5 - public function getName() { 6 - return pht('Support'); 7 - } 8 - 9 - public function canUninstall() { 10 - return false; 11 - } 12 - 13 - public function isUnlisted() { 14 - return true; 15 - } 16 - 17 - public function getRoutes() { 18 - return array( 19 - '/help/' => array( 20 - 'keyboardshortcut/' => 'PhabricatorHelpKeyboardShortcutController', 21 - ), 22 - ); 23 - } 24 - 25 - }