recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix creation of "subtask created" entries in parent task timeline

Summary:
`ManiphestTaskStatusTransaction::TRANSACTIONTYPE` is not used anymore when creating new tasks since rPd321cc810aab52be00d75c9dcfa8b9cabd34828e in 2017.

Among the transactions when creating a subtask is `ManiphestTaskParentTransaction::TRANSACTIONTYPE` which provides the data we're looking for, in order to reach the `if ($this->getMetadataValue('blocker.new'))` check in `ManiphestTaskUnblockTransaction::getTitle()`.
(`PhabricatorCoreCreateTransaction` does not provide `$unblock_xaction->getOldValue()` nor `$unblock_xaction->getOldValue()`.)

Closes T16275

Test Plan: * Go to a Maniphest task and select 'Edit Related Tasks > Create Subtask', create a subtask, look at the timeline of the parent task.

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16314, T16275

Differential Revision: https://we.phorge.it/D26439

Andre Klapper 5dfed69a c8d48635

+1
+1
src/applications/maniphest/editor/ManiphestTransactionEditor.php
··· 101 101 $unblock_xaction = null; 102 102 foreach ($xactions as $xaction) { 103 103 switch ($xaction->getTransactionType()) { 104 + case ManiphestTaskParentTransaction::TRANSACTIONTYPE: 104 105 case ManiphestTaskStatusTransaction::TRANSACTIONTYPE: 105 106 $unblock_xaction = $xaction; 106 107 break;