recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

PHP 8.5: Fix null array key for color in PhabricatorIconRemarkupRule

Summary:
Setting null as an array key is deprecated since PHP 8.5 per https://www.php.net/releases/8.5/en.php: "Using null as an array offset or when calling array_key_exists() is now deprecated. Use an empty string instead."

```
ERROR 8192: Using null as an array offset is deprecated, use an empty string instead at [/var/www/html/phorge/phorge/src/applications/macro/markup/PhabricatorIconRemarkupRule.php:70]
```

Closes T16446

Test Plan: Unknown

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: mainframe98, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16446

Differential Revision: https://we.phorge.it/D26764

Andre Klapper 5e05a583 bf21c6ee

+1 -1
+1 -1
src/applications/macro/markup/PhabricatorIconRemarkupRule.php
··· 67 67 } 68 68 69 69 $color = $options['color']; 70 - if (empty($color_names[$color])) { 70 + if ($color !== null && empty($color_names[$color])) { 71 71 $color = null; 72 72 } 73 73