@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Provide a missing feed transaction string for space creation
Summary:
Fixes T12502. This transaction probably should not be getting picked for feed rendering, but it currently does get selected in some cases.
This should probably be revisited eventually (e.g., when Maniphest moves to ModularTransactions) but just fix the brokenness for now.
Test Plan:
- Created a task in a space.
- Viewed feed.
- Saw the story render with readable text.
{F4555747}
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T12502
Differential Revision: https://secure.phabricator.com/D17609
+14
-6
+14
-6
src/applications/transactions/storage/PhabricatorApplicationTransaction.php
+14
-6
src/applications/transactions/storage/PhabricatorApplicationTransaction.php
···
1149
1149
$this->renderHandleLink($author_phid),
1150
1150
$this->renderHandleLink($object_phid));
1151
1151
case PhabricatorTransactions::TYPE_SPACE:
1152
-
return pht(
1153
-
'%s shifted %s from the %s space to the %s space.',
1154
-
$this->renderHandleLink($author_phid),
1155
-
$this->renderHandleLink($object_phid),
1156
-
$this->renderHandleLink($old),
1157
-
$this->renderHandleLink($new));
1152
+
if ($this->getIsCreateTransaction()) {
1153
+
return pht(
1154
+
'%s created %s in the %s space.',
1155
+
$this->renderHandleLink($author_phid),
1156
+
$this->renderHandleLink($object_phid),
1157
+
$this->renderHandleLink($new));
1158
+
} else {
1159
+
return pht(
1160
+
'%s shifted %s from the %s space to the %s space.',
1161
+
$this->renderHandleLink($author_phid),
1162
+
$this->renderHandleLink($object_phid),
1163
+
$this->renderHandleLink($old),
1164
+
$this->renderHandleLink($new));
1165
+
}
1158
1166
case PhabricatorTransactions::TYPE_EDGE:
1159
1167
$new = ipull($new, 'dst');
1160
1168
$old = ipull($old, 'dst');