+13 -13

resources/celerity/map.php

reviewed

··· 9 9 'names' => array( 10 10 'conpherence.pkg.css' => 'b1547973', 11 11 'conpherence.pkg.js' => '11f3e07e', 12 12 - 'core.pkg.css' => 'cfc3eabe', 12 12 + 'core.pkg.css' => 'ade19c40', 13 13 'core.pkg.js' => '975d6a27', 14 14 'darkconsole.pkg.js' => 'e7393ebb', 15 15 'differential.pkg.css' => 'e1d704ce', ··· 38 38 'rsrc/css/application/base/notification-menu.css' => 'b3ab500d', 39 39 'rsrc/css/application/base/phabricator-application-launch-view.css' => '95351601', 40 40 'rsrc/css/application/base/phui-theme.css' => '027ba77e', 41 41 - 'rsrc/css/application/base/standard-page-view.css' => '79176f5a', 41 41 + 'rsrc/css/application/base/standard-page-view.css' => 'e5d90676', 42 42 'rsrc/css/application/chatlog/chatlog.css' => 'd295b020', 43 43 'rsrc/css/application/conduit/conduit-api.css' => '7bc725c4', 44 44 'rsrc/css/application/config/config-options.css' => '0ede4c9b', ··· 102 102 'rsrc/css/application/releeph/releeph-preview-branch.css' => 'b7a6f4a5', 103 103 'rsrc/css/application/releeph/releeph-request-differential-create-dialog.css' => '8d8b92cd', 104 104 'rsrc/css/application/releeph/releeph-request-typeahead.css' => '667a48ae', 105 105 - 'rsrc/css/application/search/application-search-view.css' => 'be6454ec', 105 105 + 'rsrc/css/application/search/application-search-view.css' => '9c9bc8dc', 106 106 'rsrc/css/application/search/search-results.css' => '7dea472c', 107 107 'rsrc/css/application/slowvote/slowvote.css' => 'a94b7230', 108 108 'rsrc/css/application/tokens/tokens.css' => '3d0f239e', 109 109 'rsrc/css/application/uiexample/example.css' => '528b19de', 110 110 - 'rsrc/css/core/core.css' => 'd0801452', 110 110 + 'rsrc/css/core/core.css' => '4f5111ea', 111 111 'rsrc/css/core/remarkup.css' => 'cd912f2c', 112 112 'rsrc/css/core/syntax.css' => '769d3498', 113 113 'rsrc/css/core/z-index.css' => '0d4e5558', ··· 125 125 'rsrc/css/phui/phui-action-list.css' => 'c5eba19d', 126 126 'rsrc/css/phui/phui-action-panel.css' => '91c7b835', 127 127 'rsrc/css/phui/phui-badge.css' => '3baef8db', 128 128 - 'rsrc/css/phui/phui-basic-nav-view.css' => '7093573b', 128 128 + 'rsrc/css/phui/phui-basic-nav-view.css' => 'c377093a', 129 129 'rsrc/css/phui/phui-big-info-view.css' => 'bd903741', 130 130 'rsrc/css/phui/phui-box.css' => '5c8387cf', 131 131 'rsrc/css/phui/phui-button.css' => '4a5fbe3d', ··· 163 163 'rsrc/css/phui/phui-tag-view.css' => '6bbd83e2', 164 164 'rsrc/css/phui/phui-timeline-view.css' => 'bc523970', 165 165 'rsrc/css/phui/phui-two-column-view.css' => 'fcfbe347', 166 166 - 'rsrc/css/phui/workboards/phui-workboard-color.css' => 'ac6fe6a7', 167 167 - 'rsrc/css/phui/workboards/phui-workboard.css' => 'e09eb53a', 166 166 + 'rsrc/css/phui/workboards/phui-workboard-color.css' => '6da20b15', 167 167 + 'rsrc/css/phui/workboards/phui-workboard.css' => 'fe70ad9c', 168 168 'rsrc/css/phui/workboards/phui-workcard.css' => '0c62d7c5', 169 169 'rsrc/css/phui/workboards/phui-workpanel.css' => '92197373', 170 170 'rsrc/css/sprite-login.css' => '6dbbbd97', ··· 611 611 'aphront-tokenizer-control-css' => '056da01b', 612 612 'aphront-tooltip-css' => '1a07aea8', 613 613 'aphront-typeahead-control-css' => 'd4f16145', 614 614 - 'application-search-view-css' => 'be6454ec', 614 614 + 'application-search-view-css' => '9c9bc8dc', 615 615 'auth-css' => '0877ed6e', 616 616 'bulk-job-css' => 'df9c1d4a', 617 617 'changeset-view-manager' => 'a2828756', ··· 844 844 'phabricator-busy' => '59a7976a', 845 845 'phabricator-chatlog-css' => 'd295b020', 846 846 'phabricator-content-source-view-css' => '4b8b05d4', 847 847 - 'phabricator-core-css' => 'd0801452', 847 847 + 'phabricator-core-css' => '4f5111ea', 848 848 'phabricator-countdown-css' => '16c52f5c', 849 849 'phabricator-dashboard-css' => 'bc6f2127', 850 850 'phabricator-drag-and-drop-file-upload' => '58dea2fa', ··· 869 869 'phabricator-shaped-request' => '7cbe244b', 870 870 'phabricator-slowvote-css' => 'a94b7230', 871 871 'phabricator-source-code-view-css' => 'cbeef983', 872 872 - 'phabricator-standard-page-view' => '79176f5a', 872 872 + 'phabricator-standard-page-view' => 'e5d90676', 873 873 'phabricator-textareautils' => '320810c8', 874 874 'phabricator-title' => 'df5e11d2', 875 875 'phabricator-tooltip' => '6323f942', ··· 896 896 'phriction-document-css' => '4282e4ad', 897 897 'phui-action-panel-css' => '91c7b835', 898 898 'phui-badge-view-css' => '3baef8db', 899 899 - 'phui-basic-nav-view-css' => '7093573b', 899 899 + 'phui-basic-nav-view-css' => 'c377093a', 900 900 'phui-big-info-view-css' => 'bd903741', 901 901 'phui-box-css' => '5c8387cf', 902 902 'phui-button-css' => '4a5fbe3d', ··· 942 942 'phui-theme-css' => '027ba77e', 943 943 'phui-timeline-view-css' => 'bc523970', 944 944 'phui-two-column-view-css' => 'fcfbe347', 945 945 - 'phui-workboard-color-css' => 'ac6fe6a7', 946 946 - 'phui-workboard-view-css' => 'e09eb53a', 945 945 + 'phui-workboard-color-css' => '6da20b15', 946 946 + 'phui-workboard-view-css' => 'fe70ad9c', 947 947 'phui-workcard-view-css' => '0c62d7c5', 948 948 'phui-workpanel-view-css' => '92197373', 949 949 'phuix-action-list-view' => 'b5c256b8',

+1 -1

src/applications/config/controller/PhabricatorConfigAllController.php

reviewed

··· 71 71 ->setCrumbs($crumbs) 72 72 ->setNavigation($nav) 73 73 ->appendChild($content) 74 74 - ->addClass('white-background'); 74 74 + ->addFrameClass('white-background'); 75 75 76 76 } 77 77

+1 -1

src/applications/config/controller/PhabricatorConfigApplicationController.php

reviewed

··· 32 32 ->setCrumbs($crumbs) 33 33 ->setNavigation($nav) 34 34 ->appendChild($content) 35 35 - ->addClass('white-background'); 35 35 + ->addFrameClass('white-background'); 36 36 } 37 37 38 38 private function buildConfigOptionsList(array $groups, $type) {

+1 -1

src/applications/config/controller/PhabricatorConfigCacheController.php

reviewed

··· 37 37 ->setCrumbs($crumbs) 38 38 ->setNavigation($nav) 39 39 ->appendChild($content) 40 40 - ->addClass('white-background'); 40 40 + ->addFrameClass('white-background'); 41 41 } 42 42 43 43 private function renderCodeBox() {

+1 -1

src/applications/config/controller/PhabricatorConfigClusterDatabasesController.php

reviewed

··· 36 36 ->setCrumbs($crumbs) 37 37 ->setNavigation($nav) 38 38 ->appendChild($content) 39 39 - ->addClass('white-background'); 39 39 + ->addFrameClass('white-background'); 40 40 } 41 41 42 42 private function buildClusterDatabaseStatus() {

+1 -1

src/applications/config/controller/PhabricatorConfigClusterNotificationsController.php

reviewed

··· 36 36 ->setCrumbs($crumbs) 37 37 ->setNavigation($nav) 38 38 ->appendChild($content) 39 39 - ->addClass('white-background'); 39 39 + ->addFrameClass('white-background'); 40 40 } 41 41 42 42 private function buildClusterNotificationStatus() {

+1 -1

src/applications/config/controller/PhabricatorConfigClusterRepositoriesController.php

reviewed

··· 42 42 ->setCrumbs($crumbs) 43 43 ->setNavigation($nav) 44 44 ->appendChild($content) 45 45 - ->addClass('white-background'); 45 45 + ->addFrameClass('white-background'); 46 46 } 47 47 48 48 private function buildClusterRepositoryStatus() {

+1 -1

src/applications/config/controller/PhabricatorConfigDatabaseIssueController.php

reviewed

··· 165 165 ->setCrumbs($crumbs) 166 166 ->setNavigation($nav) 167 167 ->appendChild($content) 168 168 - ->addClass('white-background'); 168 168 + ->addFrameClass('white-background'); 169 169 } 170 170 171 171 }

+1 -1

src/applications/config/controller/PhabricatorConfigDatabaseStatusController.php

reviewed

··· 117 117 ->setCrumbs($crumbs) 118 118 ->setNavigation($nav) 119 119 ->appendChild($content) 120 120 - ->addClass('white-background'); 120 120 + ->addFrameClass('white-background'); 121 121 } 122 122 123 123

+1 -1

src/applications/config/controller/PhabricatorConfigGroupController.php

reviewed

··· 43 43 ->setCrumbs($crumbs) 44 44 ->setNavigation($nav) 45 45 ->appendChild($content) 46 46 - ->addClass('white-background'); 46 46 + ->addFrameClass('white-background'); 47 47 } 48 48 49 49 private function buildOptionList(array $options) {

+1 -1

src/applications/config/controller/PhabricatorConfigHistoryController.php

reviewed

··· 50 50 ->setCrumbs($crumbs) 51 51 ->setNavigation($nav) 52 52 ->appendChild($content) 53 53 - ->addClass('white-background'); 53 53 + ->addFrameClass('white-background'); 54 54 } 55 55 56 56 }

+1 -1

src/applications/config/controller/PhabricatorConfigIssueListController.php

reviewed

··· 68 68 ->setCrumbs($crumbs) 69 69 ->setNavigation($nav) 70 70 ->appendChild($content) 71 71 - ->addClass('white-background'); 71 71 + ->addFrameClass('white-background'); 72 72 } 73 73 74 74 private function buildIssueList(array $issues, $group, $fonticon) {

+1 -1

src/applications/config/controller/PhabricatorConfigIssueViewController.php

reviewed

··· 46 46 ->setCrumbs($crumbs) 47 47 ->setNavigation($nav) 48 48 ->appendChild($content) 49 49 - ->addClass('white-background'); 49 49 + ->addFrameClass('white-background'); 50 50 } 51 51 52 52 private function renderIssue(PhabricatorSetupIssue $issue) {

+1 -1

src/applications/config/controller/PhabricatorConfigListController.php

reviewed

··· 32 32 ->setCrumbs($crumbs) 33 33 ->setNavigation($nav) 34 34 ->appendChild($content) 35 35 - ->addClass('white-background'); 35 35 + ->addFrameClass('white-background'); 36 36 } 37 37 38 38 private function buildConfigOptionsList(array $groups, $type) {

+1 -1

src/applications/config/controller/PhabricatorConfigModuleController.php

reviewed

··· 36 36 ->setCrumbs($crumbs) 37 37 ->setNavigation($nav) 38 38 ->appendChild($content) 39 39 - ->addClass('white-background'); 39 39 + ->addFrameClass('white-background'); 40 40 } 41 41 42 42 }

+1 -1

src/applications/config/controller/PhabricatorConfigVersionController.php

reviewed

··· 31 31 ->setCrumbs($crumbs) 32 32 ->setNavigation($nav) 33 33 ->appendChild($content) 34 34 - ->addClass('white-background'); 34 34 + ->addFrameClass('white-background'); 35 35 36 36 } 37 37

+1 -1

src/applications/home/controller/PhabricatorHomeMainController.php

reviewed

··· 46 46 47 47 return $this->newPage() 48 48 ->setTitle('Phabricator') 49 49 - ->addClass('phabricator-home') 49 49 + ->addFrameClass('phabricator-home') 50 50 ->appendChild($content); 51 51 52 52 }

+2 -2

src/applications/project/controller/PhabricatorProjectBoardViewController.php

reviewed

··· 455 455 require_celerity_resource('phui-workboard-color-css'); 456 456 $background_color_class = "phui-workboard-{$background}"; 457 457 458 458 - $page->addClass('phui-workboard-color'); 459 459 - $page->addClass($background_color_class); 458 458 + $page->addFrameClass('phui-workboard-color'); 459 459 + $page->addFrameClass($background_color_class); 460 460 } 461 461 462 462 return $page;

+2 -2

src/applications/search/controller/PhabricatorApplicationSearchController.php

reviewed

··· 320 320 $crumbs->addTextCrumb($title); 321 321 } 322 322 323 323 - $nav->addClass('application-search-view'); 324 323 require_celerity_resource('application-search-view-css'); 325 324 326 325 return $this->newPage() ··· 328 327 ->setTitle(pht('Query: %s', $title)) 329 328 ->setCrumbs($crumbs) 330 329 ->setNavigation($nav) 330 330 + ->addFrameClass('application-search-view') 331 331 ->appendChild($body); 332 332 } 333 333 ··· 419 419 ->setObjectList($list) 420 420 ->addClass('application-search-results'); 421 421 422 422 - $nav->addClass('application-search-view'); 423 422 require_celerity_resource('application-search-view-css'); 424 423 425 424 return $this->newPage() ··· 427 426 ->setTitle(pht('Saved Queries')) 428 427 ->setCrumbs($crumbs) 429 428 ->setNavigation($nav) 429 429 + ->addFrameClass('application-search-view') 430 430 ->appendChild($box); 431 431 } 432 432

+17 -3

src/view/page/PhabricatorStandardPageView.php

reviewed

··· 13 13 private $menuContent; 14 14 private $showChrome = true; 15 15 private $classes = array(); 16 16 + private $frameClasses = array(); 16 17 private $disableConsole; 17 18 private $pageObjects = array(); 18 19 private $applicationMenu; ··· 77 78 78 79 public function addClass($class) { 79 80 $this->classes[] = $class; 81 81 + return $this; 82 82 + } 83 83 + 84 84 + public function addFrameClass($class) { 85 85 + $this->frameClasses[] = $class; 80 86 return $this; 81 87 } 82 88 ··· 528 534 } 529 535 $nav->appendChild($body); 530 536 $nav->appendFooter($footer); 531 531 - $content = phutil_implode_html('', array($nav->render())); 537 537 + $content = $nav; 532 538 } else { 533 539 $content = array(); 534 540 ··· 539 545 540 546 $content[] = $body; 541 547 $content[] = $footer; 548 548 + } 542 549 543 543 - $content = phutil_implode_html('', $content); 544 544 - } 550 550 + $frame_classes = $this->frameClasses; 551 551 + $frame_classes[] = 'main-page-background'; 552 552 + 553 553 + $content = phutil_tag( 554 554 + 'div', 555 555 + array( 556 556 + 'class' => implode(' ', $frame_classes), 557 557 + ), 558 558 + $content); 545 559 546 560 return array( 547 561 ($console ? hsprintf('<darkconsole />') : null),

+12 -1

webroot/rsrc/css/application/base/standard-page-view.css

reviewed

··· 17 17 clear: both; 18 18 } 19 19 20 20 - body.white-background { 20 20 + .main-page-background { 21 21 + position: absolute; 22 22 + top: 44px; 23 23 + bottom: 0; 24 24 + left: 0; 25 25 + right: 0; 26 26 + overflow: scroll; 27 27 + z-index: -1; 28 28 + background: {$page.background}; 29 29 + } 30 30 + 31 31 + .main-page-background.white-background { 21 32 background: #fff; 22 33 } 23 34

+10

webroot/rsrc/css/application/search/application-search-view.css

reviewed

··· 11 11 padding: 0 16px 24px; 12 12 } 13 13 14 14 + .device-phone .application-search-view 15 15 + .application-search-results.phui-object-box { 16 16 + padding: 0 8px 24px; 17 17 + } 18 18 + 14 19 .application-search-view .application-search-results .phui-profile-header { 15 20 padding: 16px 8px; 16 21 border-bottom: 1px solid {$thinblueborder}; ··· 53 58 .device-phone .application-search-pager { 54 59 margin: 12px; 55 60 } 61 61 + 62 62 + .device-phone .application-search-view .application-search-results 63 63 + .phui-profile-header { 64 64 + padding-top: 12px; 65 65 + }

+6 -1

webroot/rsrc/css/core/core.css

reviewed

··· 42 42 font-weight: bold; 43 43 } 44 44 45 45 + html{ 46 46 + min-height: 100%; 47 47 + position: relative; 48 48 + } 49 49 + 45 50 body { 46 51 font: {$basefont}; 47 52 direction: ltr; 48 53 text-align: left; 49 54 unicode-bidi: embed; 50 50 - background: {$page.background}; 55 55 + height: 100%; 51 56 52 57 /* By default, the iPhone zooms all text on the page by some percentage when 53 58 you rotate from portrait mode to landscape mode. Disable this, since it

+3 -3

webroot/rsrc/css/phui/phui-basic-nav-view.css

reviewed

··· 3 3 */ 4 4 5 5 .device-desktop .phui-navigation-shell, 6 6 - .phabricator-home.device .phui-navigation-shell { 6 6 + .device .phabricator-home .phui-navigation-shell { 7 7 display: table; 8 8 width: 100%; 9 9 height: calc(100vh - {$menu.main.height}); 10 10 } 11 11 12 12 .device-desktop .phui-navigation-shell .phabricator-nav, 13 13 - .phabricator-home.device .phui-navigation-shell .phabricator-nav { 13 13 + .device .phabricator-home .phui-navigation-shell .phabricator-nav { 14 14 display: table-row; 15 15 } 16 16 17 17 .device-desktop .phui-navigation-shell .phabricator-nav-local, 18 18 - .phabricator-home.device .phui-navigation-shell .phabricator-nav-local { 18 18 + .device .phabricator-home .phui-navigation-shell .phabricator-nav-local { 19 19 display: table-cell; 20 20 position: relative; 21 21 vertical-align: top;

+2 -2

webroot/rsrc/css/phui/workboards/phui-workboard-color.css

reviewed

··· 30 30 background-color: rgba({$alphawhite},.6); 31 31 } 32 32 33 33 - body.phui-workboard-color .phui-profile-menu .phabricator-side-menu { 33 33 + body .phui-workboard-color .phui-profile-menu .phabricator-side-menu { 34 34 background-color: rgba({$alphagrey},.3); 35 35 } 36 36 37 37 - body.phui-workboard-color .phabricator-side-menu .phui-profile-menu-footer-1 { 37 37 + body .phui-workboard-color .phabricator-side-menu .phui-profile-menu-footer-1 { 38 38 background-color: transparent; 39 39 } 40 40

+6 -3

webroot/rsrc/css/phui/workboards/phui-workboard.css

reviewed

··· 14 14 overflow-x: auto; 15 15 overflow-y: hidden; 16 16 position: absolute; 17 17 - top: 79px; 17 17 + top: 32px; 18 18 bottom: 0; 19 19 left: 0; 20 20 right: 0; 21 21 padding: 16px; 22 22 - background-color: #fff; 23 22 } 24 23 25 24 .phui-workboard-view-shadow::-webkit-scrollbar { ··· 75 74 display: none; 76 75 } 77 76 77 77 + .device-desktop .phui-workboard-fullscreen .main-page-background { 78 78 + top: 0; 79 79 + } 80 80 + 78 81 .device-desktop .phui-workboard-fullscreen .phui-profile-menu 79 82 .phui-workboard-view-shadow { 80 80 - top: 35px; 83 83 + top: 32px; 81 84 left: 0; 82 85 } 83 86