@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
bin/config set: mention database possibly overriding local settings
Summary: Fixes T16399
Test Plan:
- Run the command with various settings defined in the database and see an error
- Run the command with settings not defined in the database and don't see an error
- Run the command with borked database settings and see it work
Reviewers: O1 Blessed Committers, mainframe98
Reviewed By: O1 Blessed Committers, mainframe98
Subscribers: mainframe98, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Maniphest Tasks: T16399
Differential Revision: https://we.phorge.it/D26596
+18
+18
src/applications/config/management/PhabricatorConfigManagementSetWorkflow.php
+18
src/applications/config/management/PhabricatorConfigManagementSetWorkflow.php
···
154
154
Filesystem::readablePath($local_path)));
155
155
}
156
156
157
+
try {
158
+
$dbstore = new PhabricatorConfigDatabaseSource('default');
159
+
$dbval = $dbstore->getKeys(array($key));
160
+
if (!empty($dbval)) {
161
+
echo tsprintf(
162
+
"<bg:yellow>** %s **</bg> %s\n",
163
+
pht('OVERRIDDEN'),
164
+
pht(
165
+
'The configuration key "%s" is already defined in the '.
166
+
'database. The value from the database will override the '.
167
+
'value in local storage.',
168
+
$key));
169
+
}
170
+
} catch (Throwable $ex) {
171
+
// The database config is hosed (or we're doing initial setup and
172
+
// don't have a database yet), just ignore
173
+
}
174
+
157
175
$write_message = pht(
158
176
'Wrote configuration key "%s" to local storage (in file "%s").',
159
177
$key,