@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Move Diffusion ReadmeView to PHUIDocumentProView
Summary: Swapping out to PHUIDocumentProView to remove all calls to PHUIDocumentView.
Test Plan: Review the Phabricator Readme.MD in Diffusion
Reviewers: epriestley, avivey
Reviewed By: avivey
Subscribers: avivey, Korvin
Differential Revision: https://secure.phabricator.com/D15308
authored by
Chad Little
and committed by
chad
5eecff91
af1fef24
+15
-13
+2
-2
resources/celerity/map.php
+2
-2
resources/celerity/map.php
···
65
65
'rsrc/css/application/differential/revision-list.css' => 'f3c47d33',
66
66
'rsrc/css/application/differential/table-of-contents.css' => 'ae4b7a55',
67
67
'rsrc/css/application/diffusion/diffusion-icons.css' => '2941baf1',
68
-
'rsrc/css/application/diffusion/diffusion-readme.css' => '2106ea08',
68
+
'rsrc/css/application/diffusion/diffusion-readme.css' => '356a4f3c',
69
69
'rsrc/css/application/diffusion/diffusion-source.css' => '075ba788',
70
70
'rsrc/css/application/feed/feed.css' => 'ecd4ec57',
71
71
'rsrc/css/application/files/global-drag-and-drop.css' => '5c1b47c2',
···
551
551
'differential-revision-list-css' => 'f3c47d33',
552
552
'differential-table-of-contents-css' => 'ae4b7a55',
553
553
'diffusion-icons-css' => '2941baf1',
554
-
'diffusion-readme-css' => '2106ea08',
554
+
'diffusion-readme-css' => '356a4f3c',
555
555
'diffusion-source-css' => '075ba788',
556
556
'diviner-shared-css' => 'aa3656aa',
557
557
'font-aleo' => '8bdb2835',
+7
-4
src/applications/diffusion/view/DiffusionReadmeView.php
+7
-4
src/applications/diffusion/view/DiffusionReadmeView.php
···
109
109
$header = id(new PHUIHeaderView())
110
110
->setHeader($readme_name);
111
111
112
-
return id(new PHUIDocumentView())
112
+
$document = id(new PHUIDocumentViewPro())
113
113
->setFluid(true)
114
-
->appendChild($readme_content)
115
-
->addClass('diffusion-readme-view')
116
-
->setHeader($header);
114
+
->appendChild($readme_content);
115
+
116
+
return id(new PHUIObjectBoxView())
117
+
->setHeader($header)
118
+
->appendChild($document)
119
+
->addClass('diffusion-readme-view');
117
120
}
118
121
119
122
}
+6
-7
webroot/rsrc/css/application/diffusion/diffusion-readme.css
+6
-7
webroot/rsrc/css/application/diffusion/diffusion-readme.css
···
2
2
* @provides diffusion-readme-css
3
3
*/
4
4
5
-
.device .diffusion-readme-view {
6
-
margin: 16px 8px 0;
7
-
background-color: #fff;
8
-
border: 1px solid {$lightblueborder};
9
-
border-bottom: 1px solid {$blueborder};
5
+
.device-desktop .diffusion-readme-view .phui-document-fluid
6
+
.phui-document-view {
7
+
margin: 0;
8
+
padding: 0 8px;
10
9
}
11
10
12
-
.device-tablet .diffusion-readme-view {
13
-
margin: 16px;
11
+
.diffusion-readme-view .phui-document-container {
12
+
border: none;
14
13
}