@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Add sound to logged out Conpherence
Summary: Fixes T12735. Adds a sound if the user is logged out, skips checking a setting.
Test Plan: set participants to null and verify sound plays, no exceptions1111
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Maniphest Tasks: T12735
Differential Revision: https://secure.phabricator.com/D17973
+11
-3
+11
-3
src/applications/conpherence/controller/ConpherenceUpdateController.php
+11
-3
src/applications/conpherence/controller/ConpherenceUpdateController.php
···
369
369
->setViewer($user);
370
370
$dropdown_query->execute();
371
371
372
-
$sounds = $this->getSoundForParticipant($user, $participant);
373
-
$receive_sound = $sounds[ConpherenceRoomSettings::SOUND_RECEIVE];
374
-
$mention_sound = $sounds[ConpherenceRoomSettings::SOUND_MENTION];
372
+
$map = ConpherenceRoomSettings::getSoundMap();
373
+
$default_receive = ConpherenceRoomSettings::DEFAULT_RECEIVE_SOUND;
374
+
$receive_sound = $map[$default_receive]['rsrc'];
375
+
$mention_sound = null;
376
+
377
+
// Get the user's defaults if logged in
378
+
if ($participant) {
379
+
$sounds = $this->getSoundForParticipant($user, $participant);
380
+
$receive_sound = $sounds[ConpherenceRoomSettings::SOUND_RECEIVE];
381
+
$mention_sound = $sounds[ConpherenceRoomSettings::SOUND_MENTION];
382
+
}
375
383
376
384
$content = array(
377
385
'non_update' => $non_update,