@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix a Diffusion issue where commits that do not show changesets would incorrectly try to render changesets
Summary:
See <https://discourse.phabricator-community.org/t/loading-certain-svn-commits-cause-unhandled-exception/3795/>.
Commits with no changesets (for example, deleted commits) don't generate a "$changesets".
Test Plan: Viewed a commit with no changesets. Before change: exception. After change: saw unusual commit state.
Differential Revision: https://secure.phabricator.com/D21175
+4
-1
+4
-1
src/applications/diffusion/controller/DiffusionCommitController.php
+4
-1
src/applications/diffusion/controller/DiffusionCommitController.php
···
459
459
460
460
$filetree = id(new DifferentialFileTreeEngine())
461
461
->setViewer($viewer)
462
-
->setChangesets($changesets)
463
462
->setDisabled(!$show_changesets);
463
+
464
+
if ($show_changesets) {
465
+
$filetree->setChangesets($changesets);
466
+
}
464
467
465
468
$description_box = id(new PHUIObjectBoxView())
466
469
->setHeaderText(pht('Description'))