recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Allow ApplicationTransactionEditor to figure out whether TYPE_COMMENT is supported or not

Summary: See D17812, etc. We can figure this out by looking at the object carefully. We don't need to go delete all the old TYPE_COMMENT (it doesn't hurt anything) but can nuke it when we see it.

Test Plan:
- Made a comment in Slowvote (supports commenting).
- Viewed an Almanac device (does not support commenting).

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D17822

epriestley 60a19e36 d467a9e3

+12 -1
-1
src/applications/slowvote/editor/PhabricatorSlowvoteEditor.php
··· 14 14 public function getTransactionTypes() { 15 15 $types = parent::getTransactionTypes(); 16 16 17 - $types[] = PhabricatorTransactions::TYPE_COMMENT; 18 17 $types[] = PhabricatorTransactions::TYPE_VIEW_POLICY; 19 18 20 19 $types[] = PhabricatorSlowvoteTransaction::TYPE_QUESTION;
+12
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
··· 298 298 } 299 299 } 300 300 301 + if ($template) { 302 + try { 303 + $comment = $template->getApplicationTransactionCommentObject(); 304 + } catch (PhutilMethodNotImplementedException $ex) { 305 + $comment = null; 306 + } 307 + 308 + if ($comment) { 309 + $types[] = PhabricatorTransactions::TYPE_COMMENT; 310 + } 311 + } 312 + 301 313 return $types; 302 314 } 303 315