recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Cast old duration values for unit tests to float in DifferentialController

Summary: Fixes T10549.

Test Plan: N/A

Reviewers: #blessed_reviewers, avivey, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin

Maniphest Tasks: T10549

Differential Revision: https://secure.phabricator.com/D15452

authored by

Burak Yigit Kaya and committed by
epriestley 60b42750 68b468a8

+10
+6
src/applications/differential/controller/DifferentialController.php
··· 190 190 } 191 191 } 192 192 193 + // Cast duration to a float since it used to be a string in some 194 + // cases. 195 + if (isset($map['duration'])) { 196 + $map['duration'] = (double)$map['duration']; 197 + } 198 + 193 199 return $map; 194 200 } 195 201
+4
src/applications/differential/controller/DifferentialRevisionViewController.php
··· 1078 1078 return null; 1079 1079 } 1080 1080 1081 + if (!$diff->getBuildable()) { 1082 + return null; 1083 + } 1084 + 1081 1085 $interesting_messages = array(); 1082 1086 foreach ($diff->getUnitMessages() as $message) { 1083 1087 switch ($message->getResult()) {