recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Don't show client-side setup prompts until user accounts activate

Summary: Fixes T11198. These are confusing or premature if you aren't an activated user: disabled or unapproved accounts won't be able to act on them.

Test Plan: Changed timezone, went through flow to correct it

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11198

Differential Revision: https://secure.phabricator.com/D16167

epriestley 60c55387 2cb77957

+5 -1
+4
src/applications/people/storage/PhabricatorUser.php
··· 94 94 * @return bool True if this is a standard, usable account. 95 95 */ 96 96 public function isUserActivated() { 97 + if (!$this->isLoggedIn()) { 98 + return false; 99 + } 100 + 97 101 if ($this->isOmnipotent()) { 98 102 return true; 99 103 }
+1 -1
src/view/page/PhabricatorStandardPageView.php
··· 222 222 } 223 223 224 224 if ($user) { 225 - if ($user->isLoggedIn()) { 225 + if ($user->isUserActivated()) { 226 226 $offset = $user->getTimeZoneOffset(); 227 227 228 228 $ignore_key = PhabricatorTimezoneIgnoreOffsetSetting::SETTINGKEY;