@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Return more transaction types in Conpherence notification menu
Summary: Unclear these are worth sending, but mostly seems useful. Returns `getTitle` for the transaction if it's not a message. Fixes T10683
Test Plan: Leave rooms, change names, add pictures.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Maniphest Tasks: T10683
Differential Revision: https://secure.phabricator.com/D16658
+13
-1
+13
-1
src/applications/conpherence/storage/ConpherenceThread.php
+13
-1
src/applications/conpherence/storage/ConpherenceThread.php
···
284
284
$message_title = null;
285
285
if ($subtitle_mode == 'message') {
286
286
$message_transaction = null;
287
+
$action_transaction = null;
287
288
foreach ($transactions as $transaction) {
288
289
switch ($transaction->getTransactionType()) {
289
290
case PhabricatorTransactions::TYPE_COMMENT:
290
291
$message_transaction = $transaction;
291
-
break 2;
292
+
break;
293
+
case ConpherenceTransaction::TYPE_TITLE:
294
+
case ConpherenceTransaction::TYPE_TOPIC:
295
+
case ConpherenceTransaction::TYPE_PICTURE:
296
+
case ConpherenceTransaction::TYPE_PARTICIPANTS:
297
+
$action_transaction = $transaction;
298
+
break;
292
299
default:
293
300
break;
294
301
}
···
302
309
->setMaximumGlyphs(60)
303
310
->truncateString(
304
311
$message_transaction->getComment()->getContent()));
312
+
}
313
+
if ($action_transaction) {
314
+
$message_title = id(clone $action_transaction)
315
+
->setRenderingTarget(PhabricatorApplicationTransaction::TARGET_TEXT)
316
+
->getTitle();
305
317
}
306
318
}
307
319
switch ($subtitle_mode) {