recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix an issue with passing HTTP headers through in proxied cluster requests

Summary:
I think this fixes the Mercurial + HTTP cluster issue. PHP adds `HTTP_` but we were not stripping it, so we would convert an `X-Whatever-Zebra` header into an `Http-X-Whatever-Zebra` header.

I don't think this behavior has changed? So maybe it just never worked? Git is more popular than Mercurial and SSH is easier to configure than HTTP, so it's plausible. I'll keep a careful eye on this when it deploys.

Test Plan:
- Set up local service-based Mercurial repository.
- Tried to clone, got similar error to cluster.
- Applied patch, clean clone.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D15660

epriestley 60e91d39 0900ffe9

+1
+1
src/aphront/AphrontRequest.php
··· 756 756 foreach ($_SERVER as $key => $value) { 757 757 if (preg_match('/^HTTP_/', $key)) { 758 758 // Unmangle the header as best we can. 759 + $key = substr($key, strlen('HTTP_')); 759 760 $key = str_replace('_', ' ', $key); 760 761 $key = strtolower($key); 761 762 $key = ucwords($key);