recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Minor phutil_tag/HTML fixes

Summary:

- In stack traces, a `,` should clearly be a `.`.
- In Calendar, a 'td' got swapped with a 'p' somewhere.
- In old-style transaction views, strlen() is no longer a sufficient test.

Test Plan:

- Verified stack traces render correctly.
- Verified calendar renders correctly.
- Verified Maniphest transactions with no comment no longer have a little empty div a few pixels high.

Reviewers: chad

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D4971

epriestley 6124865c d8d16ece

+29 -29
+25 -25
src/__celerity_resource_map__.php
··· 599 599 ), 600 600 'aphront-calendar-view-css' => 601 601 array( 602 - 'uri' => '/res/87d6e40d/rsrc/css/aphront/calendar-view.css', 602 + 'uri' => '/res/73061a31/rsrc/css/aphront/calendar-view.css', 603 603 'type' => 'css', 604 604 'requires' => 605 605 array( ··· 2419 2419 ), 2420 2420 'javelin-workflow' => 2421 2421 array( 2422 - 'uri' => '/res/519c4e1a/rsrc/js/javelin/lib/Workflow.js', 2422 + 'uri' => '/res/1535e366/rsrc/js/javelin/lib/Workflow.js', 2423 2423 'type' => 'js', 2424 2424 'requires' => 2425 2425 array( ··· 2868 2868 ), 2869 2869 'phabricator-pinboard-view-css' => 2870 2870 array( 2871 - 'uri' => '/res/b954ccbf/rsrc/css/layout/phabricator-pinboard-view.css', 2871 + 'uri' => '/res/79be6f49/rsrc/css/layout/phabricator-pinboard-view.css', 2872 2872 'type' => 'css', 2873 2873 'requires' => 2874 2874 array( ··· 3415 3415 ), 3416 3416 'tokens-css' => 3417 3417 array( 3418 - 'uri' => '/res/c1f6113c/rsrc/css/application/tokens/tokens.css', 3418 + 'uri' => '/res/6b3c65c7/rsrc/css/application/tokens/tokens.css', 3419 3419 'type' => 'css', 3420 3420 'requires' => 3421 3421 array( ··· 3597 3597 'uri' => '/res/pkg/f96657b8/diffusion.pkg.js', 3598 3598 'type' => 'js', 3599 3599 ), 3600 - 'd466c034' => 3600 + 'a69b9f1f' => 3601 3601 array( 3602 3602 'name' => 'javelin.pkg.js', 3603 3603 'symbols' => ··· 3622 3622 17 => 'javelin-typeahead-ondemand-source', 3623 3623 18 => 'javelin-tokenizer', 3624 3624 ), 3625 - 'uri' => '/res/pkg/d466c034/javelin.pkg.js', 3625 + 'uri' => '/res/pkg/a69b9f1f/javelin.pkg.js', 3626 3626 'type' => 'js', 3627 3627 ), 3628 3628 'e30a3fa8' => ··· 3683 3683 'global-drag-and-drop-css' => 'acc46105', 3684 3684 'inline-comment-summary-css' => '8aaacd1b', 3685 3685 'javelin-aphlict' => 'bc0774e5', 3686 - 'javelin-behavior' => 'd466c034', 3686 + 'javelin-behavior' => 'a69b9f1f', 3687 3687 'javelin-behavior-aphlict-dropdown' => 'bc0774e5', 3688 3688 'javelin-behavior-aphlict-listen' => 'bc0774e5', 3689 3689 'javelin-behavior-aphront-basic-tokenizer' => 'bc0774e5', ··· 3731 3731 'javelin-behavior-repository-crossreference' => '95d0d865', 3732 3732 'javelin-behavior-toggle-class' => 'bc0774e5', 3733 3733 'javelin-behavior-workflow' => 'bc0774e5', 3734 - 'javelin-dom' => 'd466c034', 3735 - 'javelin-event' => 'd466c034', 3736 - 'javelin-install' => 'd466c034', 3737 - 'javelin-json' => 'd466c034', 3738 - 'javelin-mask' => 'd466c034', 3739 - 'javelin-request' => 'd466c034', 3740 - 'javelin-resource' => 'd466c034', 3741 - 'javelin-stratcom' => 'd466c034', 3742 - 'javelin-tokenizer' => 'd466c034', 3743 - 'javelin-typeahead' => 'd466c034', 3744 - 'javelin-typeahead-normalizer' => 'd466c034', 3745 - 'javelin-typeahead-ondemand-source' => 'd466c034', 3746 - 'javelin-typeahead-preloaded-source' => 'd466c034', 3747 - 'javelin-typeahead-source' => 'd466c034', 3748 - 'javelin-uri' => 'd466c034', 3749 - 'javelin-util' => 'd466c034', 3750 - 'javelin-vector' => 'd466c034', 3751 - 'javelin-workflow' => 'd466c034', 3734 + 'javelin-dom' => 'a69b9f1f', 3735 + 'javelin-event' => 'a69b9f1f', 3736 + 'javelin-install' => 'a69b9f1f', 3737 + 'javelin-json' => 'a69b9f1f', 3738 + 'javelin-mask' => 'a69b9f1f', 3739 + 'javelin-request' => 'a69b9f1f', 3740 + 'javelin-resource' => 'a69b9f1f', 3741 + 'javelin-stratcom' => 'a69b9f1f', 3742 + 'javelin-tokenizer' => 'a69b9f1f', 3743 + 'javelin-typeahead' => 'a69b9f1f', 3744 + 'javelin-typeahead-normalizer' => 'a69b9f1f', 3745 + 'javelin-typeahead-ondemand-source' => 'a69b9f1f', 3746 + 'javelin-typeahead-preloaded-source' => 'a69b9f1f', 3747 + 'javelin-typeahead-source' => 'a69b9f1f', 3748 + 'javelin-uri' => 'a69b9f1f', 3749 + 'javelin-util' => 'a69b9f1f', 3750 + 'javelin-vector' => 'a69b9f1f', 3751 + 'javelin-workflow' => 'a69b9f1f', 3752 3752 'lightbox-attachment-css' => 'acc46105', 3753 3753 'maniphest-task-summary-css' => 'e30a3fa8', 3754 3754 'maniphest-transaction-detail-css' => 'e30a3fa8',
+1 -1
src/aphront/configuration/AphrontDefaultApplicationConfiguration.php
··· 382 382 return hsprintf( 383 383 '<div class="exception-trace">'. 384 384 '<div class="exception-trace-header">Stack Trace</div>'. 385 - '%s', 385 + '%s'. 386 386 '</div>', 387 387 $table->render()); 388 388 }
+1 -1
src/applications/calendar/view/AphrontCalendarMonthView.php
··· 131 131 $row[] = $empty_box; 132 132 } 133 133 foreach ($row as $cell) { 134 - $table[] = phutil_tag('p', array(), $cell); 134 + $table[] = phutil_tag('td', array(), $cell); 135 135 } 136 136 $table[] = hsprintf('</tr>'); 137 137 }
+1 -1
src/view/layout/PhabricatorTransactionView.php
··· 137 137 138 138 private function renderTransactionContent() { 139 139 $content = $this->renderChildren(); 140 - if (!$content) { 140 + if ($this->isEmptyContent($content)) { 141 141 return null; 142 142 } 143 143 return phutil_tag(
+1 -1
webroot/rsrc/css/aphront/calendar-view.css
··· 91 91 overflow: hidden; 92 92 } 93 93 94 - .aphront-calendar-event a { 94 + .aphront-calendar-event a:link { 95 95 color: #fff; 96 96 } 97 97