@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix some pagination/redirect issues for repositories
Summary:
Ref T10923. Paging wasn't being applied correctly when creating //new// repositories after API changes.
Also, the first redirect after creation wasn't sending users to the right place.
Test Plan:
- Created a new repostiory, got redirected properly.
- Verified that new repostiory flow has the correct fields (name, callsign, etc) and Conduit API has the correct fields (everything).
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T10923
Differential Revision: https://secure.phabricator.com/D15865
+11
+11
src/applications/transactions/editengine/PhabricatorEditEngine.php
+11
src/applications/transactions/editengine/PhabricatorEditEngine.php
···
497
497
}
498
498
499
499
public function getEffectiveObjectViewURI($object) {
500
+
if ($this->getIsCreate()) {
501
+
return $this->getObjectViewURI($object);
502
+
}
503
+
500
504
$page = $this->getSelectedPage();
501
505
if ($page) {
502
506
$view_uri = $page->getViewURI();
···
839
843
}
840
844
841
845
$page_key = $request->getURIData('pageKey');
846
+
if (!strlen($page_key)) {
847
+
$pages = $this->getPages($object);
848
+
if ($pages) {
849
+
$page_key = head_key($pages);
850
+
}
851
+
}
852
+
842
853
if (strlen($page_key)) {
843
854
$page = $this->selectPage($object, $page_key);
844
855
if (!$page) {