@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Hide "Signed with MFA" stories from feed
Summary:
See <https://discourse.phabricator-community.org/t/sign-with-mfa-action-on-differential-revisions-creates-strange-feed-entries/2346>.
If you "Sign with MFA" and only add a comment, we can produce a weird notification and feed story. Hide these stories from feed since they're broadly not interesting.
Test Plan:
- Used "sign with MFA" and only posted a comment.
- Observed feed.
- Before: Janky "untitled story".
- After: Sensible "added a comment" story.
Reviewers: amckinley
Reviewed By: amckinley
Differential Revision: https://secure.phabricator.com/D20071
+2
-1
+2
-1
src/applications/transactions/storage/PhabricatorApplicationTransaction.php
+2
-1
src/applications/transactions/storage/PhabricatorApplicationTransaction.php
···
740
740
741
741
switch ($this->getTransactionType()) {
742
742
case PhabricatorTransactions::TYPE_TOKEN:
743
+
case PhabricatorTransactions::TYPE_MFA:
743
744
return true;
744
-
case PhabricatorTransactions::TYPE_EDGE:
745
+
case PhabricatorTransactions::TYPE_EDGE:
745
746
$edge_type = $this->getMetadataValue('edge:type');
746
747
switch ($edge_type) {
747
748
case PhabricatorObjectMentionsObjectEdgeType::EDGECONST: