recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix changeset construction special case for empty commits in pre-commit hooks

Summary: Fixes T13155. Ref T13151. A recent change (D19455) changed the return format here, but I missed this special case for empty commits.

Test Plan:
- T13155 has a good set of reproduction instructions.
- Pushed an empty commit.
- Before: bunch of warning log spew.
- After: clean logs.

Reviewers: amckinley, avivey

Reviewed By: avivey

Maniphest Tasks: T13155, T13151

Differential Revision: https://secure.phabricator.com/D19500

epriestley 6136b832 9db5ad34

+1 -1
+1 -1
src/applications/diffusion/engine/DiffusionCommitHookEngine.php
··· 1212 1212 1213 1213 if (!strlen($raw_diff)) { 1214 1214 // If the commit is actually empty, just return no changesets. 1215 - return array(); 1215 + return array(array(), 0); 1216 1216 } 1217 1217 1218 1218 $parser = new ArcanistDiffParser();