@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove a check for closing revisions
Summary:
I ran into a case where a commit isn't "new" but hasn't been closed. I
think the check on the status of the differential revision should be
enough and this check isn't needed.
Test Plan:
used the reparse.php script to close a revision that previously wouldn't
close.
Reviewers: epriestley, vrana
Reviewed By: vrana
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D3232
+1
-3
+1
-3
src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
+1
-3
src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
···
106
106
DifferentialRevision::TABLE_COMMIT,
107
107
$revision->getID(),
108
108
$commit->getPHID());
109
-
$commit_is_new = $conn_w->getAffectedRows();
110
109
111
110
$committer_phid = $data->getCommitDetail('committerPHID');
112
111
if ($committer_phid) {
···
142
141
$revision->getAuthorPHID());
143
142
144
143
$status_closed = ArcanistDifferentialRevisionStatus::CLOSED;
145
-
$should_close = $commit_is_new &&
146
-
($revision->getStatus() != $status_closed) &&
144
+
$should_close = ($revision->getStatus() != $status_closed) &&
147
145
$repository->shouldAutocloseCommit($commit, $data);
148
146
149
147
if ($should_close) {