recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix the visibility of `PhutilDaemon::run` methods

Summary: Ref T6822. This method is only called from `PhutilDaemon::execute()` and can be made `protected`.

Test Plan: See D11404.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6822

Differential Revision: https://secure.phabricator.com/D11405

Joshua Spence 62dfcd1e 94b96ae5

+5 -5
+1 -1
src/applications/fact/daemon/PhabricatorFactDaemon.php
··· 6 6 7 7 const RAW_FACT_BUFFER_LIMIT = 128; 8 8 9 - public function run() { 9 + protected function run() { 10 10 $this->setEngines(PhabricatorFactEngine::loadAllEngines()); 11 11 while (!$this->shouldExit()) { 12 12 $iterators = $this->getAllApplicationIterators();
+1 -1
src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php
··· 34 34 /** 35 35 * @task pull 36 36 */ 37 - public function run() { 37 + protected function run() { 38 38 $argv = $this->getArgv(); 39 39 array_unshift($argv, __CLASS__); 40 40 $args = new PhutilArgumentParser($argv);
+1 -1
src/infrastructure/daemon/bot/PhabricatorBot.php
··· 16 16 private $config; 17 17 private $pollFrequency; 18 18 19 - public function run() { 19 + protected function run() { 20 20 $argv = $this->getArgv(); 21 21 if (count($argv) !== 1) { 22 22 throw new Exception('usage: PhabricatorBot <json_config_file>');
+1 -1
src/infrastructure/daemon/garbagecollector/PhabricatorGarbageCollectorDaemon.php
··· 6 6 */ 7 7 final class PhabricatorGarbageCollectorDaemon extends PhabricatorDaemon { 8 8 9 - public function run() { 9 + protected function run() { 10 10 $collectors = id(new PhutilSymbolLoader()) 11 11 ->setAncestorClass('PhabricatorGarbageCollector') 12 12 ->loadObjects();
+1 -1
src/infrastructure/daemon/workers/PhabricatorTaskmasterDaemon.php
··· 2 2 3 3 final class PhabricatorTaskmasterDaemon extends PhabricatorDaemon { 4 4 5 - public function run() { 5 + protected function run() { 6 6 $sleep = 0; 7 7 do { 8 8 $tasks = id(new PhabricatorWorkerLeaseQuery())