@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Conpherence - make threads loadable as handles
Summary: Fixes T3403
Test Plan: looked at /mail/ and saw sensible values as pertained to Conpherence threads.
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Maniphest Tasks: T3403
Differential Revision: https://secure.phabricator.com/D6370
+32
-1
+32
-1
src/applications/phid/handle/PhabricatorObjectHandleData.php
+32
-1
src/applications/phid/handle/PhabricatorObjectHandleData.php
···
219
219
->execute();
220
220
return mpull($legds, null, 'getPHID');
221
221
222
+
case PhabricatorPHIDConstants::PHID_TYPE_CONP:
223
+
$confs = id(new ConpherenceThreadQuery())
224
+
->withPHIDs($phids)
225
+
->setViewer($this->viewer)
226
+
->execute();
227
+
return mpull($confs, null, 'getPHID');
228
+
229
+
222
230
}
223
231
224
232
return array();
···
738
746
$handle->setPHID($phid);
739
747
$handle->setType($type);
740
748
if (empty($objects[$phid])) {
741
-
$handle->setName('Unknown Legalpad Document');
749
+
$handle->setName(pht('Unknown Legalpad Document'));
742
750
} else {
743
751
$document = $objects[$phid];
744
752
$handle->setName($document->getDocumentBody()->getTitle());
···
749
757
$handles[$phid] = $handle;
750
758
}
751
759
break;
760
+
761
+
case PhabricatorPHIDConstants::PHID_TYPE_CONP:
762
+
foreach ($phids as $phid) {
763
+
$handle = new PhabricatorObjectHandle();
764
+
$handle->setPHID($phid);
765
+
$handle->setType($type);
766
+
if (empty($objects[$phid])) {
767
+
$handle->setName(pht('Unknown Conpherence Thread'));
768
+
} else {
769
+
$thread = $objects[$phid];
770
+
$name = $thread->getTitle();
771
+
if (!strlen($name)) {
772
+
$name = pht('[No Title]');
773
+
}
774
+
$handle->setName($name);
775
+
$handle->setFullName($name);
776
+
$handle->setURI('/conpherence/'.$thread->getID().'/');
777
+
$handle->setComplete(true);
778
+
}
779
+
$handles[$phid] = $handle;
780
+
}
781
+
break;
782
+
752
783
753
784
default:
754
785
$loader = null;