@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Link to PHP Docs about MySQLi report mode; add a TODO

Summary:
Link to canonical docs explaining the current `mysqli_report(MYSQLI_REPORT_OFF)` behavior.
Remove useless reference to old upstream task which is just a generic PHP 8.1 issue.
For reference, related commit was https://web.archive.org/web/20250326045742/http://secure.phabricator.com/D21744

Test Plan: None; it is a comment only.

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: mainframe98, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D26499

+7 -5
+7 -5
src/infrastructure/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php
··· 57 57 } 58 58 } 59 59 60 - // See T13588. In PHP 8.1, the default "report mode" for MySQLi has 61 - // changed, which causes MySQLi to raise exceptions. Disable exceptions 62 - // to align behavior with older default behavior under MySQLi, which 63 - // this code expects. Plausibly, this code could be updated to use 64 - // MySQLi exceptions to handle errors under a wider range of PHP versions. 60 + // In PHP 8.1, the default "report mode" for MySQLi has changed, which 61 + // causes MySQLi to raise exceptions. Disable exceptions to align behavior 62 + // with older default behavior under MySQLi, which this code expects. 63 + // https://www.php.net/manual/mysqli-driver.report-mode.php 64 + // https://www.php.net/manual/migration81.incompatible.php#migration81.incompatible.mysqli 65 + // TODO: Plausibly, this code could be updated to use MySQLi exceptions 66 + // to handle errors. See https://we.phorge.it/T16341 65 67 mysqli_report(MYSQLI_REPORT_OFF); 66 68 67 69 $conn = mysqli_init();