@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove arcanist projects from Herald
Summary: Ref T7604. Remove arcanist projects from Herald. Depends on D12894 and D12957.
Test Plan: See D12957.
Reviewers: epriestley, #blessed_reviewers
Reviewed By: epriestley, #blessed_reviewers
Subscribers: johnny-bit, Korvin, epriestley
Maniphest Tasks: T7604
Differential Revision: https://secure.phabricator.com/D12896
+13
-24
+13
-13
resources/celerity/map.php
+13
-13
resources/celerity/map.php
···
331
331
'rsrc/js/application/aphlict/behavior-aphlict-listen.js' => 'b1a59974',
332
332
'rsrc/js/application/aphlict/behavior-aphlict-status.js' => 'ea681761',
333
333
'rsrc/js/application/auth/behavior-persona-login.js' => '9414ff18',
334
-
'rsrc/js/application/calendar/behavior-day-view.js' => '28a60488',
334
+
'rsrc/js/application/calendar/behavior-day-view.js' => '5c46cff2',
335
335
'rsrc/js/application/calendar/behavior-event-all-day.js' => '38dcf3c8',
336
336
'rsrc/js/application/config/behavior-reorder-fields.js' => '14a827de',
337
337
'rsrc/js/application/conpherence/ConpherenceThreadManager.js' => '10246726',
···
370
370
'rsrc/js/application/doorkeeper/behavior-doorkeeper-tag.js' => 'e5822781',
371
371
'rsrc/js/application/files/behavior-icon-composer.js' => '8ef9ab58',
372
372
'rsrc/js/application/files/behavior-launch-icon-composer.js' => '48086888',
373
-
'rsrc/js/application/herald/HeraldRuleEditor.js' => '9229e764',
373
+
'rsrc/js/application/herald/HeraldRuleEditor.js' => '271ffdd7',
374
374
'rsrc/js/application/herald/PathTypeahead.js' => 'f7fc67ec',
375
375
'rsrc/js/application/herald/herald-rule-editor.js' => '7ebaeed3',
376
376
'rsrc/js/application/maniphest/behavior-batch-editor.js' => 'f5d1233b',
···
526
526
'global-drag-and-drop-css' => '697324ad',
527
527
'harbormaster-css' => '49d64eb4',
528
528
'herald-css' => '826075fa',
529
-
'herald-rule-editor' => '9229e764',
529
+
'herald-rule-editor' => '271ffdd7',
530
530
'herald-test-css' => '778b008e',
531
531
'homepage-panel-css' => 'e34bf140',
532
532
'inline-comment-summary-css' => 'eb5f8e8c',
···
554
554
'javelin-behavior-dashboard-move-panels' => '82439934',
555
555
'javelin-behavior-dashboard-query-panel-select' => '453c5375',
556
556
'javelin-behavior-dashboard-tab-panel' => 'd4eecc63',
557
-
'javelin-behavior-day-view' => '28a60488',
557
+
'javelin-behavior-day-view' => '5c46cff2',
558
558
'javelin-behavior-device' => 'a205cf28',
559
559
'javelin-behavior-differential-add-reviewers-and-ccs' => 'e10f8e18',
560
560
'javelin-behavior-differential-comment-jump' => '4fdb476d',
···
1000
1000
'phabricator-drag-and-drop-file-upload',
1001
1001
'phabricator-draggable-list',
1002
1002
),
1003
+
'271ffdd7' => array(
1004
+
'multirow-row-manager',
1005
+
'javelin-install',
1006
+
'javelin-util',
1007
+
'javelin-dom',
1008
+
'javelin-stratcom',
1009
+
'javelin-json',
1010
+
'phabricator-prefab',
1011
+
),
1003
1012
'2818f5ce' => array(
1004
1013
'javelin-install',
1005
1014
'javelin-util',
···
1516
1525
'javelin-behavior',
1517
1526
'javelin-dom',
1518
1527
'javelin-stratcom',
1519
-
),
1520
-
'9229e764' => array(
1521
-
'multirow-row-manager',
1522
-
'javelin-install',
1523
-
'javelin-util',
1524
-
'javelin-dom',
1525
-
'javelin-stratcom',
1526
-
'javelin-json',
1527
-
'phabricator-prefab',
1528
1528
),
1529
1529
93568464 => array(
1530
1530
'javelin-behavior',
-6
src/applications/herald/adapter/HeraldAdapter.php
-6
src/applications/herald/adapter/HeraldAdapter.php
···
42
42
const FIELD_APPLICATION_EMAIL = 'applicaton-email';
43
43
const FIELD_TASK_PRIORITY = 'taskpriority';
44
44
const FIELD_TASK_STATUS = 'taskstatus';
45
-
const FIELD_ARCANIST_PROJECT = 'arcanist-project';
46
45
const FIELD_PUSHER_IS_COMMITTER = 'pusher-is-committer';
47
46
const FIELD_PATH = 'path';
48
47
···
100
99
const VALUE_BUILD_PLAN = 'buildplan';
101
100
const VALUE_TASK_PRIORITY = 'taskpriority';
102
101
const VALUE_TASK_STATUS = 'taskstatus';
103
-
const VALUE_ARCANIST_PROJECT = 'arcanistprojects';
104
102
const VALUE_LEGAL_DOCUMENTS = 'legaldocuments';
105
103
const VALUE_APPLICATION_EMAIL = 'applicationemail';
106
104
···
385
383
self::FIELD_APPLICATION_EMAIL => pht('Receiving email address'),
386
384
self::FIELD_TASK_PRIORITY => pht('Task priority'),
387
385
self::FIELD_TASK_STATUS => pht('Task status'),
388
-
self::FIELD_ARCANIST_PROJECT => pht('Arcanist Project'),
389
386
self::FIELD_PUSHER_IS_COMMITTER => pht('Pusher same as committer'),
390
387
self::FIELD_PATH => pht('Path'),
391
388
) + $this->getCustomFieldNameMap();
···
441
438
case self::FIELD_PUSHER:
442
439
case self::FIELD_TASK_PRIORITY:
443
440
case self::FIELD_TASK_STATUS:
444
-
case self::FIELD_ARCANIST_PROJECT:
445
441
return array(
446
442
self::CONDITION_IS_ANY,
447
443
self::CONDITION_IS_NOT_ANY,
···
946
942
return self::VALUE_TASK_PRIORITY;
947
943
case self::FIELD_TASK_STATUS:
948
944
return self::VALUE_TASK_STATUS;
949
-
case self::FIELD_ARCANIST_PROJECT:
950
-
return self::VALUE_ARCANIST_PROJECT;
951
945
default:
952
946
return self::VALUE_USER;
953
947
}
-3
src/applications/herald/adapter/HeraldDifferentialRevisionAdapter.php
-3
src/applications/herald/adapter/HeraldDifferentialRevisionAdapter.php
···
80
80
self::FIELD_AFFECTED_PACKAGE,
81
81
self::FIELD_AFFECTED_PACKAGE_OWNER,
82
82
self::FIELD_IS_NEW_OBJECT,
83
-
self::FIELD_ARCANIST_PROJECT,
84
83
),
85
84
parent::getFields());
86
85
}
···
259
258
$packages = $this->loadAffectedPackages();
260
259
return PhabricatorOwnersOwner::loadAffiliatedUserPHIDs(
261
260
mpull($packages, 'getID'));
262
-
case self::FIELD_ARCANIST_PROJECT:
263
-
return $this->revision->getArcanistProjectPHID();
264
261
}
265
262
266
263
return parent::getHeraldField($field);
-1
src/applications/herald/controller/HeraldRuleController.php
-1
src/applications/herald/controller/HeraldRuleController.php
···
626
626
'taskpriority' => new ManiphestTaskPriorityDatasource(),
627
627
'taskstatus' => new ManiphestTaskStatusDatasource(),
628
628
'buildplan' => new HarbormasterBuildPlanDatasource(),
629
-
'arcanistprojects' => new DiffusionArcanistProjectDatasource(),
630
629
'package' => new PhabricatorOwnersPackageDatasource(),
631
630
'project' => new PhabricatorProjectDatasource(),
632
631
'user' => new PhabricatorPeopleDatasource(),