recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Add abstract getRequestExceptionHandlerDescription to AphrontRequestExceptionHandler

Summary:
PhabricatorConfigRequestExceptionHandlerModule::renderModuleStatus calls
this method on all AphrontRequestExceptionHandlers, but implementing the
method is not required. This breaks /config/module/exception-handler/
when a custom exception handler does not implement it.

Test Plan:
Before applying this change:
* Create a new RequestExceptionHandler in src/extensions/ and omit getRequestExceptionHandlerDescription
* Visit http://phorge.localhost/config/module/exception-handler/ and see an exception
After applying this change:
* PHP fatal error about missing method
* Add getRequestEceptionHandlerDescription
* See the description on http://phorge.localhost/config/module/exception-handler/

Reviewers: O1 Blessed Committers, avivey

Reviewed By: O1 Blessed Committers, avivey

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D26570

mainframe98 63bce19d 360e135c

+2
+2
src/aphront/handler/AphrontRequestExceptionHandler.php
··· 10 10 */ 11 11 abstract class AphrontRequestExceptionHandler extends Phobject { 12 12 13 + abstract public function getRequestExceptionHandlerDescription(); 14 + 13 15 abstract public function getRequestExceptionHandlerPriority(); 14 16 15 17 abstract public function canHandleRequestThrowable(