@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Suggest branch name in Next Step
Summary: Is this correct for Mercurial?
Test Plan: Saw it.
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D4957
+14
-3
+1
-1
src/applications/differential/controller/DifferentialRevisionViewController.php
+1
-1
src/applications/differential/controller/DifferentialRevisionViewController.php
···
228
228
229
229
$revision_detail = new DifferentialRevisionDetailView();
230
230
$revision_detail->setRevision($revision);
231
-
$revision_detail->setDiff(reset($diffs));
231
+
$revision_detail->setDiff(end($diffs));
232
232
$revision_detail->setAuxiliaryFields($aux_fields);
233
233
234
234
$actions = $this->getRevisionActions($revision);
+13
-2
src/applications/differential/view/DifferentialRevisionDetailView.php
+13
-2
src/applications/differential/view/DifferentialRevisionDetailView.php
···
69
69
if ($status == ArcanistDifferentialRevisionStatus::ACCEPTED) {
70
70
switch ($local_vcs) {
71
71
case PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL:
72
+
$bookmark = $this->getDiff()->getBookmark();
73
+
$command = ($bookmark != ''
74
+
? csprintf('arc land %s', $bookmark)
75
+
: 'arc land');
76
+
break;
77
+
72
78
case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT:
73
-
$next_step = phutil_tag('tt', array(), 'arc land');
79
+
$branch = $this->getDiff()->getBranch();
80
+
$command = ($branch != ''
81
+
? csprintf('arc land %s', $branch)
82
+
: 'arc land');
74
83
break;
84
+
75
85
case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN:
76
-
$next_step = phutil_tag('tt', array(), 'arc commit');
86
+
$command = 'arc commit';
77
87
break;
78
88
}
89
+
$next_step = phutil_tag('tt', array(), $command);
79
90
}
80
91
if ($next_step) {
81
92
$properties->addProperty(pht('Next Step'), $next_step);