@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Restore date validation errors to Calendar
Summary: Ref T9275. I waffled back and forth on these transactions a bit, but put these back here in better working order.
Test Plan: Tried to schedule an event on "taco".
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T9275
Differential Revision: https://secure.phabricator.com/D16285
+28
+28
src/applications/calendar/editor/PhabricatorCalendarEventEditor.php
+28
src/applications/calendar/editor/PhabricatorCalendarEventEditor.php
···
465
465
}
466
466
}
467
467
break;
468
+
case PhabricatorCalendarEventTransaction::TYPE_START_DATE:
469
+
case PhabricatorCalendarEventTransaction::TYPE_END_DATE:
470
+
case PhabricatorCalendarEventTransaction::TYPE_RECURRENCE_END_DATE:
471
+
foreach ($xactions as $xaction) {
472
+
if ($xaction->getNewValue()->isValid()) {
473
+
continue;
474
+
}
475
+
476
+
switch ($type) {
477
+
case PhabricatorCalendarEventTransaction::TYPE_START_DATE:
478
+
$message = pht('Start date is invalid.');
479
+
break;
480
+
case PhabricatorCalendarEventTransaction::TYPE_END_DATE:
481
+
$message = pht('End date is invalid.');
482
+
break;
483
+
case PhabricatorCalendarEventTransaction::TYPE_RECURRENCE_END_DATE:
484
+
$message = pht('Repeat until date is invalid.');
485
+
break;
486
+
}
487
+
488
+
$errors[] = new PhabricatorApplicationTransactionValidationError(
489
+
$type,
490
+
pht('Invalid'),
491
+
$message,
492
+
$xaction);
493
+
}
494
+
break;
495
+
468
496
}
469
497
470
498
return $errors;