@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Don't prompt to mark notifications as read if we don't need to
Summary: Fixes whatever task is tracking this junk, if one exists. Don't prompt unless there's a security issue.
Test Plan:
- Generated notifications from a test account.
- Clicked "Mark All" from dropdown menu, no prompt.
- Clicked "Mark All" from notifications screen, no prompt.
- Command-Clicked "Mark All" from dropdown menu to open in new window, got normal prompt.
Reviewers: chad
Reviewed By: chad
Differential Revision: https://secure.phabricator.com/D18483
+11
+11
src/applications/notification/controller/PhabricatorNotificationClearController.php
+11
src/applications/notification/controller/PhabricatorNotificationClearController.php
···
8
8
$chrono_key = $request->getStr('chronoKey');
9
9
10
10
if ($request->isDialogFormPost()) {
11
+
$should_clear = true;
12
+
} else {
13
+
try {
14
+
$request->validateCSRF();
15
+
$should_clear = true;
16
+
} catch (AphrontMalformedRequestException $ex) {
17
+
$should_clear = false;
18
+
}
19
+
}
20
+
21
+
if ($should_clear) {
11
22
$table = new PhabricatorFeedStoryNotification();
12
23
13
24
queryfx(