@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix query frequency unit and change time preference from input to dropdown.
Summary: Ref T8362, Fix query frequency unit and change time preference from input to dropdown.
Test Plan: Change user time preference in Date Time Settings panel, open feed, observe new time stamps.
Reviewers: #blessed_reviewers, epriestley
Reviewed By: #blessed_reviewers, epriestley
Subscribers: epriestley, Korvin
Maniphest Tasks: T8362
Differential Revision: https://secure.phabricator.com/D13236
+6
-15
+1
-1
src/applications/calendar/storage/PhabricatorCalendarEvent.php
+1
-1
src/applications/calendar/storage/PhabricatorCalendarEvent.php
+5
-14
src/applications/settings/panel/PhabricatorDateTimeSettingsPanel.php
+5
-14
src/applications/settings/panel/PhabricatorDateTimeSettingsPanel.php
···
58
58
->setName('timezone')
59
59
->setOptions($timezone_id_map)
60
60
->setValue($user->getTimezoneIdentifier()))
61
-
->appendRemarkupInstructions(
62
-
pht(
63
-
"**Custom Date and Time Formats**\n\n".
64
-
"You can specify custom formats which will be used when ".
65
-
"rendering dates and times of day. Examples:\n\n".
66
-
"| Format | Example | Notes |\n".
67
-
"| ------ | -------- | ----- |\n".
68
-
"| `g:i A` | 2:34 PM | Default 12-hour time. |\n".
69
-
"| `G.i a` | 02.34 pm | Alternate 12-hour time. |\n".
70
-
"| `H:i` | 14:34 | 24-hour time. |\n".
71
-
"\n\n".
72
-
"You can find a [[%s | full reference in the PHP manual]].",
73
-
'http://www.php.net/manual/en/function.date.php'))
74
61
->appendChild(
75
-
id(new AphrontFormTextControl())
62
+
id(new AphrontFormSelectControl())
76
63
->setLabel(pht('Time-of-Day Format'))
77
64
->setName($pref_time)
65
+
->setOptions(array(
66
+
'g:i A' => pht('12-hour (2:34 PM)'),
67
+
'H:i' => pht('24-hour (14:34)'),
68
+
))
78
69
->setCaption(
79
70
pht('Format used when rendering a time of day.'))
80
71
->setValue($preferences->getPreference($pref_time)))